Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck DINO loss #1762

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Typecheck DINO loss #1762

merged 3 commits into from
Dec 30, 2024

Conversation

philippmwirth
Copy link
Contributor

Typecheck DINO loss

Typecheck DINO loss and tests. I had to refactor the tests a bit but the cases should not have changed.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (38a93c4) to head (34cbd72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         162      162           
  Lines        6739     6740    +1     
=======================================
+ Hits         5745     5746    +1     
  Misses        994      994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open question.

lightly/loss/dino_loss.py Show resolved Hide resolved
tests/loss/test_dino_loss.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippmwirth philippmwirth merged commit cb36313 into master Dec 30, 2024
14 checks passed
@philippmwirth philippmwirth deleted the philipp-typecheck-dino-loss branch December 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants