Skip to content

Move from bounds on low-level objects to BP Send bounds #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

Rather than bounding the traits used in `OutputSweeper`, move the
bounds to where we actually require them - a top-level `Send` bound
on the `Deref`-to-`OutputSweeper` type itself.

Based on #3734

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented May 13, 2025

I've assigned @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz May 13, 2025 15:12
joostjager
joostjager previously approved these changes May 13, 2025
Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to understand how it works now.

Rather than bounding the traits used in `OutputSweeper`, move the
bounds to where we actually require them - a top-level `Send` bound
on the `Deref`-to-`OutputSweeper` type itself.
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (f015545) to head (61cd37d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3776   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         157      157           
  Lines      125450   125450           
  Branches   125450   125450           
=======================================
  Hits       112305   112305           
+ Misses      10445    10442    -3     
- Partials     2700     2703    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt
Copy link
Collaborator Author

Rebased after dependent PR got merged.

@jkczyz jkczyz merged commit edc71d5 into lightningdevkit:main May 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants