Break up and function-ize handle_new_monitor_update
#4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll be breaking up this macro in upcoming commits.
Makes handle_new_monitor_update more readable.
Finishes work over the past few commits of breaking up the handle_new_monitor_update macro.
|
👋 Hi! I see this is a draft PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4138 +/- ##
==========================================
- Coverage 88.62% 88.60% -0.02%
==========================================
Files 180 180
Lines 134895 135247 +352
Branches 134895 135247 +352
==========================================
+ Hits 119546 119839 +293
- Misses 12587 12643 +56
- Partials 2762 2765 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joostjager
reviewed
Oct 6, 2025
| }}; | ||
| } | ||
|
|
||
| macro_rules! handle_new_monitor_update_todo_name { |
There was a problem hiding this comment.
handle_new_monitor_update_in_context, because it pulls data from the given chan_context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefactor to some of @joostjager's experimental work including serialized channels in
ChannelMonitorUpdates as part of getting rid ofChannelManagerpersistence.