Skip to content

Conversation

@tankyleo
Copy link
Contributor

Millisatoshi truncation also contributes to the value of the anchor output on a zero-fee commitment transaction.

Millisatoshi truncation also contributes to the value of the anchor
output on a zero-fee commitment transaction.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 20, 2025

👋 Thanks for assigning @carlaKC as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from carlaKC November 20, 2025 17:52
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

IMO can be merged with one review ✅

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (6d9c676) to head (fd12205).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4237      +/-   ##
==========================================
- Coverage   89.32%   89.31%   -0.02%     
==========================================
  Files         180      180              
  Lines      138641   138641              
  Branches   138641   138641              
==========================================
- Hits       123844   123826      -18     
- Misses      12174    12193      +19     
+ Partials     2623     2622       -1     
Flag Coverage Δ
fuzzing 35.97% <ø> (ø)
tests 88.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tankyleo tankyleo merged commit bb5504e into lightningdevkit:main Nov 21, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants