multi: be consistent with UTC conversion of timestamp #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorT-11
reviewed
Feb 12, 2025
| func (s *sessionRpcServer) AddSession(ctx context.Context, | ||
| req *litrpc.AddSessionRequest) (*litrpc.AddSessionResponse, error) { | ||
|
|
||
| expiry := time.Unix(int64(req.ExpiryTimestampSeconds), 0) |
There was a problem hiding this comment.
I think this one should also be:
Suggested change
| expiry := time.Unix(int64(req.ExpiryTimestampSeconds), 0) | |
| expiry := time.Unix(int64(req.ExpiryTimestampSeconds), 0).UTC() |
Or we need to update protos to declare that the timestamp should explicitly be sent in through the request in UTC?
| return nil, fmt.Errorf("must include at least one feature") | ||
| } | ||
|
|
||
| expiry := time.Unix(int64(req.ExpiryTimestampSeconds), 0) |
Comment on lines
135
to
+137
| startTime := time.Now().Add( | ||
| -time.Duration(rateLim.NumHours) * time.Hour, | ||
| ) | ||
| ).UTC() |
There was a problem hiding this comment.
This should be:
startTime := time.Now().UTC().Add(
-time.Duration(rateLim.NumHours) * time.Hour,
)
Else there can be an discrepancy when the local timezone conversion happens right at a boundary of DST.
|
thank goodness we dont need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we convert to UTC timestamps at persistence read/write time, we gotta make sure to compare against a consistent
Localwhen comparing againsttime.Now()in the code.