Skip to content

[sql-16] sessions: update Store interface methods to take a context #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 28, 2025

Conversation

ellemouton
Copy link
Member

@ellemouton ellemouton commented Feb 25, 2025

In preparation for adding a SQL implementation of the Store interface, which will make calls that require a context, we update the store interface such that all methods take a context.

Many commits but all just passing context through. So review load is small.

@ellemouton ellemouton self-assigned this Feb 25, 2025
@ellemouton ellemouton force-pushed the sql16Sessions8 branch 2 times, most recently from 433293f to 7989c0d Compare February 26, 2025 07:00
@ellemouton ellemouton added the no-changelog This PR is does not require a release notes entry label Feb 26, 2025
Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🔥!

Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡ just two questions

@ellemouton ellemouton merged commit 66b0f15 into lightninglabs:master Feb 28, 2025
19 of 21 checks passed
@ellemouton ellemouton deleted the sql16Sessions8 branch February 28, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR is does not require a release notes entry sql-ize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants