Skip to content

Conversation

@starius
Copy link
Collaborator

@starius starius commented Nov 20, 2025

  • add StopDaemon RPC with permissions + REST binding
  • expose loop stop CLI (with optional --wait) and wait logic
  • pass daemon shutdown callback + unit test and regenerate docs/protos

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

* add StopDaemon RPC with permissions + REST binding
* expose `loop stop` CLI (with optional --wait) and wait logic
* pass daemon shutdown callback + unit test and regenerate docs/protos
@starius starius marked this pull request as ready for review November 20, 2025 03:05
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it including --wait, its a great feature to simplify testing code!

LGTM!

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! 🎉

@starius starius merged commit 62419ab into lightninglabs:master Nov 21, 2025
6 checks passed
@starius starius deleted the loop-stop branch November 21, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants