rpcserver: check blockbeatDispatcher when deciding isSynced
#9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
added
code health
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yyforyongyu
changed the title
blockbeatDispatcher when deciding isSynced
yyforyongyu
force-pushed
the
getinfo-blockheight
branch
from
6eb149d to
e987478
Compare
|
There's a flake in the itest which will be fixed in #9448. |
Add a new method `CurrentHeight` to query the current best height of the dispatcher.
This commit changes `GetInfo` to include `blockbeatDispatcher`'s current state when deciding whether the system is synced to chain. Previously we check the best height against the wallet and the channel graph, we should also do this to the blockbeat dispatcher to make sure the internal consumers are also synced to the best block.
yyforyongyu
force-pushed
the
getinfo-blockheight
branch
from
e987478 to
759dc20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
GetInfoto includeblockbeatDispatcher's current state when deciding whether the system is synced to chain. Previously we check the best height against the wallet and the channel graph, we should also do this to the blockbeat dispatcher to make sure the internal consumers are also synced to the best block.I think this also fixes a few itest flakes due to blocks being mined too fast and the subsystems are not in sync, such as #9486.