Add a Nix flake with packages for colgrep and a devshell#114
Merged
Conversation
Collaborator
|
Hi @fu5ha, thank you for the MR ! Merging it right now 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic
flake.nixwhich provides:colgrepandcolgrep-cudapackagesThis can be used by developers to quickly obtain a development environment using Nix, and can be used like so to add a specific colgrep package to a flake-based Nix environment like NixOS, home-manager, etc like so:
It currently uses a semi-ugly wrapper style where we just inject environment variables. Ideally, the Rust packages that pull in the libs that need this wrapping (onnx-runtime, cuda libs) could be modified to allow link-time dynamic linking for these, which would then allow Nix's RPATH patching to let them link against the location of the libs in the Nix store without the need for wrapping with env vars. But, this isn't necessarily the end of the world for now.