Skip to content

LCORE-1602: Update LCORE version#1437

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1602-update-lcore-version
Mar 31, 2026
Merged

LCORE-1602: Update LCORE version#1437
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1602-update-lcore-version

Conversation

@tisnik

@tisnik tisnik commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-1602: Update LCORE version

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1602

Summary by CodeRabbit

  • Chores
    • Version number updated from 0.4.2 to 0.5.0 across release documentation, API specifications, Splunk integration documentation, observability examples, and test fixtures to reflect the current release version.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 42829e9f-c1e7-452a-bde7-15cb3ae49a36

📥 Commits

Reviewing files that changed from the base of the PR and between 1b68d36 and dbc9619.

📒 Files selected for processing (9)
  • README.md
  • docs/openapi.json
  • docs/splunk.md
  • src/observability/README.md
  • src/version.py
  • tests/e2e/features/info.feature
  • tests/integration/endpoints/test_rlsapi_v1_integration.py
  • tests/unit/app/endpoints/conftest.py
  • tests/unit/observability/formats/test_rlsapi.py
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: E2E: library mode / ci
  • GitHub Check: E2E: server mode / ci
🧰 Additional context used
📓 Path-based instructions (6)
**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

Use absolute imports for internal modules from the Lightspeed Core Stack (e.g., from authentication import get_auth_dependency)

Files:

  • tests/unit/app/endpoints/conftest.py
  • tests/integration/endpoints/test_rlsapi_v1_integration.py
  • src/version.py
  • tests/unit/observability/formats/test_rlsapi.py
tests/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

tests/**/*.py: Use pytest for all unit and integration tests; do not use unittest
Maintain test coverage of at least 60% for unit tests and 10% for integration tests

Files:

  • tests/unit/app/endpoints/conftest.py
  • tests/integration/endpoints/test_rlsapi_v1_integration.py
  • tests/unit/observability/formats/test_rlsapi.py
tests/**/conftest.py

📄 CodeRabbit inference engine (AGENTS.md)

Use conftest.py for shared test fixtures in pytest

Files:

  • tests/unit/app/endpoints/conftest.py
tests/unit/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

Use pytest-mock for AsyncMock objects in unit tests

Files:

  • tests/unit/app/endpoints/conftest.py
  • tests/unit/observability/formats/test_rlsapi.py
tests/e2e/features/**/*.feature

📄 CodeRabbit inference engine (AGENTS.md)

Use behave (BDD) framework with Gherkin feature files for end-to-end tests

Files:

  • tests/e2e/features/info.feature
src/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.py: Use FastAPI imports from the fastapi module: from fastapi import APIRouter, HTTPException, Request, status, Depends
Use from llama_stack_client import AsyncLlamaStackClient for Llama Stack client imports
Check constants.py for shared constants before defining new ones
All modules must start with descriptive docstrings explaining purpose
Use logger = get_logger(__name__) from log.py for module logging
Define type aliases at module level for clarity in Lightspeed Core Stack
All functions require docstrings with brief descriptions following Google Python docstring conventions
Use complete type annotations for function parameters and return types
Use modern union type syntax str | int instead of Union[str, int] for type annotations
Use Optional[Type] for nullable types in type annotations
Use snake_case with descriptive, action-oriented names for functions (e.g., get_, validate_, check_)
Avoid in-place parameter modification anti-patterns; return new data structures instead
Use async def for functions performing I/O operations and external API calls
Handle APIConnectionError from Llama Stack in error handling logic
Use standard log levels appropriately: debug for diagnostic info, info for general execution, warning for unexpected events, error for serious problems
All classes require descriptive docstrings explaining their purpose
Use PascalCase for class names with descriptive names and standard suffixes (Configuration, Error/Exception, Resolver, Interface)
Use ABC (Abstract Base Classes) with @abstractmethod decorators for interface implementations
Use complete type annotations for all class attributes; avoid using Any type
Follow Google Python docstring conventions with Parameters, Returns, Raises, and Attributes sections as needed

Files:

  • src/version.py
🧠 Learnings (1)
📚 Learning: 2025-08-18T10:56:55.349Z
Learnt from: matysek
Repo: lightspeed-core/lightspeed-stack PR: 292
File: pyproject.toml:0-0
Timestamp: 2025-08-18T10:56:55.349Z
Learning: The lightspeed-stack project intentionally uses a "generic image" approach, bundling many dependencies directly in the base runtime image to work for everyone, rather than using lean base images with optional dependency groups.

Applied to files:

  • README.md
🪛 Checkov (3.2.510)
docs/openapi.json

[high] 1-13998: Ensure that the global security field has rules defined

(CKV_OPENAPI_4)


[high] 1-13998: Ensure that security operations is not empty.

(CKV_OPENAPI_5)

🔇 Additional comments (10)
src/version.py (1)

12-12: LGTM! Version constant correctly updated.

The version bump from 0.4.2 to 0.5.0 is a clean minor version increment following semantic versioning conventions. This constant serves as the single source of truth for the project version.

tests/unit/app/endpoints/conftest.py (1)

20-20: LGTM! Mock User-Agent header updated consistently.

The User-Agent header in the mock request factory correctly reflects the new version CLA/0.5.0, ensuring unit tests validate behavior with the updated version string.

src/observability/README.md (2)

33-33: LGTM! Documentation example updated consistently.

The example code correctly demonstrates the new version CLA/0.5.0 in the InferenceEventData payload, keeping the documentation in sync with the actual service version.


1-95: All version references are correctly updated—no remaining references to 0.4.2 found.

The search results confirm that no hardcoded references to the old version 0.4.2 or CLA/0.4.2 remain in the codebase. The README example uses the correct version CLA/0.5.0, which matches the current version defined in src/version.py (__version__ = "0.5.0"). Version consistency is maintained across the codebase.

docs/openapi.json (1)

16-16: Version bump is consistent with the service source of truth.

info.version now matches src/version.py and aligns with the schema generation flow.

README.md (1)

9-9: Version badge link update looks correct.

The release link now correctly targets 0.5.0 and matches the version bump scope.

docs/splunk.md (1)

88-88: Splunk payload example version is correctly bumped.

cla_version now reflects CLA/0.5.0, which keeps telemetry docs aligned with the release.

tests/e2e/features/info.feature (1)

18-18: E2E info assertion update is correct.

The expected service version 0.5.0 matches the endpoint contract for this release.

tests/unit/observability/formats/test_rlsapi.py (1)

20-20: Unit test fixture and assertion are consistently updated.

Both the input fixture and expected output now correctly validate CLA/0.5.0.

Also applies to: 43-43

tests/integration/endpoints/test_rlsapi_v1_integration.py (1)

47-47: Mock User-Agent version bump is correct.

This keeps integration test request metadata aligned with 0.5.0.


Walkthrough

Version bump from 0.4.2 to 0.5.0 applied consistently across the application's version constant, API documentation, release badge, event documentation, test fixtures, and test assertions.

Changes

Cohort / File(s) Summary
Version constant
src/version.py
Updated __version__ from 0.4.2 to 0.5.0.
Documentation and API metadata
README.md, docs/openapi.json, docs/splunk.md, src/observability/README.md
Updated version references from 0.4.2 to 0.5.0 in release badge, OpenAPI specification, event payload documentation, and example payloads.
Test files
tests/e2e/features/info.feature, tests/integration/endpoints/test_rlsapi_v1_integration.py, tests/unit/app/endpoints/conftest.py, tests/unit/observability/formats/test_rlsapi.py
Updated expected and mocked version strings in test fixtures, mocks, and assertions from 0.4.2/CLA/0.4.2 to 0.5.0/CLA/0.5.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-1602: Update LCORE version' is directly related to the changeset, which updates the service version from 0.4.2 to 0.5.0 across all configuration, documentation, and test files.
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik

tisnik commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tisnik

tisnik commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@tisnik
tisnik merged commit 4f47e10 into lightspeed-core:main Mar 31, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant