Skip to content

LCORE-3049: Consistent PydanticAI-based modules naming convention#2147

Merged
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-3049
Jul 15, 2026
Merged

LCORE-3049: Consistent PydanticAI-based modules naming convention#2147
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-3049

Conversation

@tisnik

@tisnik tisnik commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-3049: Consistent PydanticAI-based modules naming convention

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-3049

Summary by CodeRabbit

  • New Features

    • Added PII redaction capability that automatically redacts sensitive information from AI interactions.
  • Documentation

    • Updated capability documentation references.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The redaction capability is implemented in _capability.py, with request/response hooks, exports, tests, and documentation updated. Llama Stack transport documentation now covers HTTPX library and server modes.

Changes

Redaction capability relocation

Layer / File(s) Summary
Redaction pipeline
src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py
Adds request- and response-side PII redaction helpers and capability hooks that preserve unchanged objects.
Module wiring and references
src/pydantic_ai_lightspeed/capabilities/redaction/__init__.py, tests/unit/pydantic_ai_lightspeed/capabilities/redaction/test_capability.py, src/pydantic_ai_lightspeed/capabilities/redaction/README.md
Updates exports, test imports, and the README link to reference _capability.py.

Llama Stack transport documentation

Layer / File(s) Summary
Transport description
src/pydantic_ai_lightspeed/llamastack/README.md
Documents HTTPX transports for both Llama Stack library and server modes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: ok-to-test

Suggested reviewers: asimurka

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main refactor: standardizing PydanticAI module naming, with docs updated as a secondary change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py (1)

34-34: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use Parameters: instead of Args: for docstring section headers.

Based on learnings and coding guidelines, the project's established format requires using Parameters: instead of Args: for function arguments, even when following Google Python docstring conventions.

  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L34-L34: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L52-L52: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L70-L70: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L97-L97: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L126-L126: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L150-L150: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L178-L178: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L199-L199: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L233-L233: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L284-L284: Change Args: to Parameters:.
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py#L309-L309: Change Args: to Parameters:.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py` at line 34,
Replace every Args: docstring section header with Parameters: in
src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py at lines 34,
52, 70, 97, 126, 150, 178, 199, 233, 284, and 309; update only these headers and
preserve all parameter descriptions and surrounding documentation.

Sources: Coding guidelines, Learnings

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py`:
- Line 34: Replace every Args: docstring section header with Parameters: in
src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py at lines 34,
52, 70, 97, 126, 150, 178, 199, 233, 284, and 309; update only these headers and
preserve all parameter descriptions and surrounding documentation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 90972ab4-b5ee-4165-9471-6ad7ab284e7c

📥 Commits

Reviewing files that changed from the base of the PR and between 216426e and 795392e.

📒 Files selected for processing (5)
  • src/pydantic_ai_lightspeed/capabilities/redaction/README.md
  • src/pydantic_ai_lightspeed/capabilities/redaction/__init__.py
  • src/pydantic_ai_lightspeed/capabilities/redaction/_capability.py
  • src/pydantic_ai_lightspeed/llamastack/README.md
  • tests/unit/pydantic_ai_lightspeed/capabilities/redaction/test_capability.py

@tisnik
tisnik merged commit 51bec44 into lightspeed-core:main Jul 15, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant