Skip to content

LCORE-2755: Agents models dump#2169

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-2755-agents-models-dump
Jul 19, 2026
Merged

LCORE-2755: Agents models dump#2169
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-2755-agents-models-dump

Conversation

@tisnik

@tisnik tisnik commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-2755: Agents models dump

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-2755

Summary by CodeRabbit

  • New Features

    • Added schemas for agent streaming events and payloads to the OpenAPI model export.
    • Added support for documenting start, end, error, interruption, token, tool-call, tool-result, and turn-completion stream payloads.
  • Tests

    • Updated schema coverage to verify all newly exported streaming payload models.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@tisnik, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b6697904-206b-487e-98da-ca1be8820a34

📥 Commits

Reviewing files that changed from the base of the PR and between 059145f and bc90bce.

📒 Files selected for processing (2)
  • src/utils/models_dumper.py
  • tests/unit/utils/test_models_dumper.py

Walkthrough

dump_models() now exports agent event and SSE streaming payload schemas. The unit test adds corresponding OpenAPI component definitions and includes their names in the expected schema set.

Changes

Agent schema export

Layer / File(s) Summary
Register agent models
src/utils/models_dumper.py
Imports agent models and adds event, payload, token, tool, and turn-completion classes to the dumped schemas.
Verify emitted schemas
tests/unit/utils/test_models_dumper.py
Adds OpenAPI schemas and expected-name assertions for start, end, error, interrupted, token, tool, base, and turn-completion streaming payloads.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main change: dumping agent models for LCORE-2755.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PASS: src/utils/models_dumper.py only appends a fixed list of extra models to a CLI-only schema dump; no new nested loops, queries, caches, or unbounded growth, and work remains one-time linear.
Security And Secret Handling ✅ Passed Only schema-export/test updates in models_dumper.py and its test; no secrets, auth, injection, or data-leak behavior added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik force-pushed the lcore-2755-agents-models-dump branch from 059145f to bc90bce Compare July 19, 2026 08:14
@tisnik
tisnik merged commit 238c498 into lightspeed-core:main Jul 19, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant