Skip to content

LCORE-3312: Refactored exception handling - #2408

Merged
tisnik merged 1 commit into
lightspeed-core:feature/upgrade-ogx-to-1.2.xfrom
asimurka:feature/exceptions-refactor
Aug 17, 2026
Merged

LCORE-3312: Refactored exception handling#2408
tisnik merged 1 commit into
lightspeed-core:feature/upgrade-ogx-to-1.2.xfrom
asimurka:feature/exceptions-refactor

Conversation

@asimurka

Copy link
Copy Markdown
Contributor

Description

Migrates OGX error handling from the legacy APIConnectionError / APIStatusError / OpenAI-style status exceptions to the unified ogx_client.ApiException model (status=None for connection failures, HTTP status otherwise), and updates endpoints, utilities, and unit/integration/e2e tests to match. Also tightens a few related paths (prompts/providers/conversations) and keeps Singleton typing compatible with mypy and pydocstyle.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 24407122-f9d0-4a42-9b39-b4318456fca3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asimurka
asimurka force-pushed the feature/exceptions-refactor branch 10 times, most recently from 4a6ddd9 to bd4d7c6 Compare August 17, 2026 10:43
@asimurka
asimurka force-pushed the feature/exceptions-refactor branch from bd4d7c6 to d194e35 Compare August 17, 2026 10:46

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit d5868f5 into lightspeed-core:feature/upgrade-ogx-to-1.2.x Aug 17, 2026
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants