LCORE-2922: Updated dependencies - #2418
Merged
tisnik merged 2 commits intoAug 12, 2026
Merged
Conversation
Contributor
WalkthroughThe ChangesDependency Version Pinning
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 83: Regenerate the Konflux dependency artifacts using make
konflux-requirements so .konflux/requirements.hashes.wheel.pypi.txt matches the
Pydantic AI 2.27.1 selection in pyproject.toml and uv.lock.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 41f8799d-9114-474a-953a-8cff001f2a1b
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
📜 Review details
⏰ Context from checks skipped due to timeout. (10)
- GitHub Check: integration_tests (3.13)
- GitHub Check: integration_tests (3.12)
- GitHub Check: build-pr
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
⚠️ CI failures not shown inline (3)
GitHub Actions: E2E Tests for Lightspeed Evaluation / E2E Tests for Lightspeed Evaluation job: LCORE-2922: Updated dependencies
Conclusion: failure
lightspeed-stack | ERROR Application startup failed. Exiting. category=server
Still waiting...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Couldn't connect to server
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/fastapi/routing.py", line 240, in merged_lifespan
lightspeed-stack | async with original_context(app) as maybe_original_state:
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/usr/lib64/python3.12/contextlib.py", line 210, in __aenter__
lightspeed-stack | return await anext(self.gen)
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/src/app/main.py", line 87, in lifespan
lightspeed-stack | await AsyncOgxClientHolder().load(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 49, in load
lightspeed-stack | await self._load_library_client(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 82, in _load_library_client
lightspeed-stack | await client.initialize()
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/library_client.py", line 413, in initialize
lightspeed-stack | await self.stack.initialize() # type: ignore
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/stack.py", line 753, in initialize
lightspeed-stack | impls = await reso...
GitHub Actions: E2E Tests for Lightspeed Evaluation / E2E Tests for Lightspeed Evaluation job: LCORE-2922: Updated dependencies
Conclusion: failure
##[group]Run echo "=== Test failure logs ==="
�[36;1mecho "=== Test failure logs ==="�[0m
�[36;1mecho "=== lightspeed-stack (library mode) logs ==="�[0m
�[36;1mdocker compose -f docker-compose-library.yaml logs lightspeed-stack�[0m
shell: /usr/bin/bash -e {0}
env:
OPENAI_***REDACTED_SECRET_ASSIGNMENT***
E2E_OPENAI_MODEL: gpt-4o-mini
FAISS_VECTOR_STORE_ID: vs_8c94967b-81cc-4028-a294-9cfac6fd9ae2
##[endgroup]
=== Test failure logs ===
=== lightspeed-stack (library mode) logs ===
lightspeed-stack | .111 INFO: Lightspeed Core Stack startup [lightspeed_stack.__main__:160]
lightspeed-stack | .114 INFO: Configuration: name='Lightspeed Core Service (LCS)' config_format_version=None service=ServiceConfiguration(host='0.0.0.0', port=8080, base_url=None, auth_enabled=False, workers=1, color_log=True, access_log=True, tls_config=TLSConfiguration(tls_certificate_path=None, tls_key_path=None, tls_key_***REDACTED_SECRET_ASSIGNMENT*** root_path='', cors=CORSConfiguration(allow_origins=['*'], allow_credentials=False, allow_methods=['*'], allow_headers=['*'])) llama_stack=LlamaStackConfiguration(url=AnyHttpUrl('http://localhost:8321/'), ***REDACTED_SECRET_ASSIGNMENT*** use_as_library_client=True, library_client_config_path='/app-root/run.yaml', timeout=180, max_retries=5, retry_delay=2, allow_degraded_mode=False, config=None) user_data_collection=UserDataCollection(feedback_enabled=True, feedback_storage='/tmp/data/feedback', transcripts_enabled=True, transcripts_storage='/tmp/data/transcripts') database=DatabaseConfiguration(sqlite=SQLiteDatabaseConfiguration(db_path='/tmp/lightspeed-stack.db'), postgres=None) mcp_servers=[] authentication=AuthenticationConfiguration(module='noop', skip_tls_verification=False, skip_for_health_probes=False, skip_for_metrics=False, k8s_cluster_api=None, k8s_ca_cert_path=None, jwk_config=None, api_key_config=None, rh_identity_config=None, trusted_proxy_config=None) authorization=None customization=None inference=Inferen...
GitHub Actions: E2E Tests for Lightspeed Evaluation / 0_E2E Tests for Lightspeed Evaluation job.txt: LCORE-2922: Updated dependencies
Conclusion: failure
lightspeed-stack | ERROR Application startup failed. Exiting. category=server
Still waiting...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Couldn't connect to server
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/fastapi/routing.py", line 240, in merged_lifespan
lightspeed-stack | async with original_context(app) as maybe_original_state:
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/usr/lib64/python3.12/contextlib.py", line 210, in __aenter__
lightspeed-stack | return await anext(self.gen)
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/src/app/main.py", line 87, in lifespan
lightspeed-stack | await AsyncOgxClientHolder().load(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 49, in load
lightspeed-stack | await self._load_library_client(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 82, in _load_library_client
lightspeed-stack | await client.initialize()
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/library_client.py", line 413, in initialize
lightspeed-stack | await self.stack.initialize() # type: ignore
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/stack.py", line 753, in initialize
lightspeed-stack | impls = await reso...
🧰 Additional context used
📓 Path-based instructions (2)
**/*
📄 CodeRabbit inference engine (Custom checks)
**/*: Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.
Flag N+1 patterns that list items and then query once per item, including Kubernetes API and database access.
Flag expensive work inside loops, including API calls, JSON parsing, and regex compilation.
Flag unbounded growth in caches, watchers, or buffers when eviction or limits are missing.
Flag missing pagination or limits on list operations and API endpoints.
Flag secrets or tokens logged in plaintext or hardcoded in source.
Flag API endpoints missing authentication or authorization.
Flag injection vulnerabilities, including SQL injection, command injection, and path traversal.
Flag sensitive data leaked in API responses, WebSocket messages, or logs.
Flag Kubernetes Secrets and Red Hat secrets missing OwnerReferences.
Files:
pyproject.toml
pyproject.toml
📄 CodeRabbit inference engine (AGENTS.md)
Check
pyproject.tomlfor supported Python versions, existing dependencies, and current library versions before adding dependencies or assuming versions.
Files:
pyproject.toml
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-07T07:02:21.046Z
Learning: Applies to pyproject.toml : Check `pyproject.toml` for supported Python versions, existing dependencies, and current library versions before adding dependencies or assuming versions.
| "tiktoken>=0.8.0", | ||
| # Used for Pydantic AI | ||
| "pydantic-ai>=2.23.0", | ||
| "pydantic-ai==2.27.1", |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n 'pydantic-ai|pydantic-ai-slim' pyproject.toml uv.lock .konflux/requirements.hashes.wheel.pypi.txt
if rg -n 'pydantic-ai==2\.26\.0|pydantic-ai-slim==2\.26\.0' .konflux/requirements.hashes.wheel.pypi.txt; then
echo "Stale pydantic-ai 2.26.0 entries remain." >&2
exit 1
fiRepository: lightspeed-core/lightspeed-stack
Length of output: 1300
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- pyproject dependency context ---'
sed -n '65,95p' pyproject.toml
printf '%s\n' '--- Konflux artifact ---'
cat -n .konflux/requirements.hashes.wheel.pypi.txt
printf '%s\n' '--- References to the Konflux requirements artifact ---'
rg -n -C 3 'requirements\.hashes\.wheel\.pypi|requirements\.hashes|pydantic-ai-slim|RHOAI is too old' .konflux .github Makefile* README.md 2>/dev/null || true
printf '%s\n' '--- Relevant lockfile package records ---'
sed -n '3160,3210p' uv.lockRepository: lightspeed-core/lightspeed-stack
Length of output: 7655
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- All references to the exact artifact ---'
rg -n -C 4 'requirements\.hashes\.wheel\.pypi\.txt' . ':!uv.lock' || true
printf '%s\n' '--- Konflux files ---'
git ls-files '.konflux/*' '.tekton/*' | sed -n '1,160p'
printf '%s\n' '--- Dependency generation documentation and scripts ---'
rg -n -C 6 'requirements\.hashes|generate.*requirement|Konflux|PyPI packages|source index' README.md scripts .github .konflux .tekton 2>/dev/null || trueRepository: lightspeed-core/lightspeed-stack
Length of output: 32222
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- Resolver inputs and pydantic overrides ---'
cat -n .konflux/requirements.overrides.txt
cat -n .konflux/pypi_wheel_only.txt
rg -n -C 8 'requirements\.overrides|pypi_wheel_only|wheel_only|pydantic-ai|pydantic-ai-slim|pydantic-evals|pydantic-graph' scripts/konflux_resolve.py scripts/konflux_requirements.sh
printf '%s\n' '--- All generated dependency pins ---'
for file in .konflux/requirements*.txt; do
printf '\n[%s]\n' "$file"
rg -n '^(pydantic-ai|pydantic-ai-slim|pydantic-evals|pydantic-graph)([<=>!~]|$)' "$file" || true
done
printf '%s\n' '--- Containerfile install path ---'
sed -n '55,82p' deploy/lightspeed-stack/ContainerfileRepository: lightspeed-core/lightspeed-stack
Length of output: 12529
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
python3 - <<'PY'
import re
import tomllib
from pathlib import Path
def pins(path):
text = Path(path).read_text()
return {
name.lower().replace("_", "-"): version
for name, version in re.findall(
r"(?m)^(?:\s*['\"])?([A-Za-z0-9][A-Za-z0-9_.-]*)==([0-9][^ '\"]*)",
text,
)
}
project = tomllib.loads(Path("pyproject.toml").read_text())
project_pins = {
item.split("==", 1)[0].lower(): item.split("==", 1)[1]
for item in project["project"]["dependencies"]
if "==" in item
}
artifact = pins(".konflux/requirements.hashes.wheel.pypi.txt")
lock_text = Path("uv.lock").read_text()
lock_pins = {
name: version
for name, version in re.findall(
r'(?ms)^\[\[package\]\]\s+name = "([^"]+)"\s+version = "([^"]+)"',
lock_text,
)
}
for name in ("pydantic-ai", "pydantic-ai-slim", "pydantic-evals", "pydantic-graph"):
print(
f"{name}: "
f"pyproject={project_pins.get(name)!r}, "
f"uv.lock={lock_pins.get(name)!r}, "
f"konflux={artifact.get(name)!r}"
)
PYRepository: lightspeed-core/lightspeed-stack
Length of output: 290
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
python3 - <<'PY'
import re
from pathlib import Path
def normalize(name):
return name.lower().replace("_", "-")
def pins(path):
text = Path(path).read_text()
return {
normalize(name): version
for name, version in re.findall(
r"(?m)^\s*['\"]?([A-Za-z0-9][A-Za-z0-9_.-]*)==([0-9][^ '\"]*)",
text,
)
}
project_text = Path("pyproject.toml").read_text()
project_pins = {
normalize(name): version
for name, version in re.findall(
r'"([A-Za-z0-9][A-Za-z0-9_.-]*)==([^"]+)"',
project_text,
)
}
artifact = pins(".konflux/requirements.hashes.wheel.pypi.txt")
lock_text = Path("uv.lock").read_text()
lock_pins = {
normalize(name): version
for name, version in re.findall(
r'(?ms)^\[\[package\]\]\s+name = "([^"]+)"\s+version = "([^"]+)"',
lock_text,
)
}
for name in ("pydantic-ai", "pydantic-ai-slim", "pydantic-evals", "pydantic-graph"):
print(
f"{name}: "
f"pyproject={project_pins.get(name)!r}, "
f"uv.lock={lock_pins.get(name)!r}, "
f"konflux={artifact.get(name)!r}"
)
PYRepository: lightspeed-core/lightspeed-stack
Length of output: 441
Regenerate the Konflux dependency artifact.
The hermetic install consumes .konflux/requirements.hashes.wheel.pypi.txt, which pins the Pydantic AI packages to 2.26.0. pyproject.toml and uv.lock select 2.27.1. Regenerate the Konflux requirements and hashes with make konflux-requirements.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pyproject.toml` at line 83, Regenerate the Konflux dependency artifacts using
make konflux-requirements so .konflux/requirements.hashes.wheel.pypi.txt matches
the Pydantic AI 2.27.1 selection in pyproject.toml and uv.lock.
Source: Coding guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LCORE-2922: Updated dependencies
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit
pydantic-aiversion to 2.27.1 for more consistent application behavior.