LCORE-3574: Added custom serializer - #2454
Merged
tisnik merged 1 commit intoAug 20, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
asimurka
force-pushed
the
feature/custom-serializer
branch
3 times, most recently
from
August 18, 2026 10:53
50c8283 to
9392cb1
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
asimurka
force-pushed
the
feature/custom-serializer
branch
from
August 18, 2026 11:51
9392cb1 to
3e05207
Compare
tisnik
merged commit Aug 20, 2026
3e0d38d
into
lightspeed-core:feature/upgrade-ogx-to-1.2.x
31 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds dump_ogx_model() via ApiClient.sanitize_for_serialization() so OGX responses and streaming chunks serialize correctly through nested OneOf fields that plain model_dump() leaves empty. The responses, prompts, and providers endpoints now use this helper instead of calling model_dump() directly on ogx_client models.
Integration tests build real OpenAIResponseObject instances instead of mocks. Unit tests patch dump_ogx_model with explicit serialized payloads where mocks are still used. Serialization behavior is covered by new tests in test_ogx_serialization.py.
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing