LCORE-2547: Renamed non-functional LLS occurrences - #2516
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 257 files, which is 157 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (257)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
asimurka
force-pushed
the
rename-lls-to-ogx
branch
2 times, most recently
from
August 26, 2026 10:36
644431f to
462480a
Compare
asimurka
force-pushed
the
rename-lls-to-ogx
branch
from
August 26, 2026 10:39
462480a to
58d667d
Compare
max-svistunov
added a commit
to max-svistunov/lightspeed-stack
that referenced
this pull request
Aug 27, 2026
…sages The startup-logging step matched "Using synthesized Llama Stack config" in library mode and "Wrote synthesized Llama Stack configuration" in server mode. The OGX rename (PRs lightspeed-core#2516 and lightspeed-core#2547) replaced both: client.py now logs "Using synthesized OGX config at %s" and llama_stack_configuration.py logs "Wrote synthesized OGX configuration to %s (mode 0600)". Neither scenario started failing, which is the reason to fix it now rather than after a real breakage. Library mode kept passing only because the sibling alternative "synthesized.*run\.yaml" incidentally matches the OGX line, the synthesized file being named run.yaml; server mode kept passing on the entrypoint's own "Using generated config:" and "mode auto-detected" echoes. Both scenarios were therefore asserting something other than the message they name, and would have gone silently unprotected the moment the output filename or the entrypoint echoes changed. Point the patterns at the current messages and record in the docstring where each one is emitted, so the next rename has an obvious place to look.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed non-functional LLS occurrences
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing