-
Notifications
You must be signed in to change notification settings - Fork 3
tests/lapi: add io tests #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b891b99
to
51b71db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
b000c92
to
eb56c5e
Compare
eb56c5e
to
78e3f21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sergey,
Thanks for the patch!
LGTM, with 2 minor nits below.
d6ca10e
to
512bdea
Compare
The patch adds tests for `io.flush()`, `io.read()`, `io.seek()`, `io.setvbuf()`, `io.write()`. Other functions are not covered.
512bdea
to
6740515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! LGTM!
Blocked by ligurio/luzer#62