Skip to content

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Jul 3, 2025

Blocked by ligurio/luzer#62

Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch!
Please consider my comments below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 17, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-io branch 2 times, most recently from b000c92 to eb56c5e Compare July 28, 2025 13:26
@ligurio ligurio marked this pull request as draft July 30, 2025 11:11
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-io branch from eb56c5e to 78e3f21 Compare August 28, 2025 14:23
@ligurio ligurio marked this pull request as ready for review August 28, 2025 14:26
@ligurio ligurio assigned Buristan and unassigned ligurio Aug 28, 2025
@ligurio ligurio requested a review from Buristan August 28, 2025 14:26
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sergey,
Thanks for the patch!
LGTM, with 2 minor nits below.

@Buristan Buristan assigned ligurio and unassigned Buristan Aug 29, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-io branch 5 times, most recently from d6ca10e to 512bdea Compare August 29, 2025 14:10
The patch adds tests for `io.flush()`, `io.read()`, `io.seek()`,
`io.setvbuf()`, `io.write()`. Other functions are not covered.
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-io branch from 512bdea to 6740515 Compare August 29, 2025 15:26
@ligurio ligurio assigned Buristan and unassigned ligurio Aug 29, 2025
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! LGTM!

@ligurio ligurio merged commit db2091f into master Aug 29, 2025
10 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-lapi-io branch August 29, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants