tests/lapi: add sysprof test #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-sysprof
branch
from
586ceda to
421cf11
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-sysprof
branch
from
421cf11 to
4172439
Compare
Buristan
requested changes
Jul 31, 2025
Buristan
requested changes
Jul 31, 2025
There was a problem hiding this comment.
[PATCH 2/2] tests/capi: omit sysprof testing
With test misc_sysprof_test.lua
added in the previous commit sysprof in luaL_loadbuffer_proto_test
is not needed anymore.
I do not agree with this:
- It handles the different API invocations (not the C callback, but the Lua function).
- The test added in the previous commit is not very useful unless the Lua mutator is added.
Thus, I suggest dropping this commit for now.
removed from the patchset (cherry-picked to the branch with |
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-sysprof
branch
from
4172439 to
08f5667
Compare
The patch adds test for sysprof built into LuaJIT.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-sysprof
branch
from
08f5667 to
fc46317
Compare
Buristan
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.