ecdh: new example demonstrating ECDH shared secret derivation #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshay-Belsare
commented
Aug 25, 2025
Akshay-Belsare
commented
- Introduced a new example utilizing the TEE_ALG_ECDH_DERIVE_SHARED_SECRET algorithm.
- This example demonstrates how to establish a shared secret using Elliptic Curve Diffie-Hellman (ECDH).
- Provides a reference for secure key exchange and cryptographic operations with ECDH in OP-TEE.
- Introduced a new example utilizing the TEE_ALG_ECDH_DERIVE_SHARED_SECRET algorithm. - This example demonstrates how to establish a shared secret using Elliptic Curve Diffie-Hellman (ECDH). - Provides a reference for secure key exchange and cryptographic operations with ECDH in OP-TEE. Signed-off-by: Amey Avinash Raghatate <[email protected]>
etienne-lms
reviewed
Sep 12, 2025
Update ecdh TA as per the review comments. Signed-off-by: Amey Avinash Raghatate <[email protected]>
etienne-lms
reviewed
Sep 23, 2025
Update ecdh TA as per the review comments Signed-off-by: Amey Avinash Raghatate <[email protected]>
Akshay-Belsare
pushed a commit
to Xilinx/optee_examples
that referenced
this pull request
Sep 29, 2025
- Introduced a new example utilizing the TEE_ALG_ECDH_DERIVE_SHARED_SECRET algorithm. - This example demonstrates how to establish a shared secret using Elliptic Curve Diffie-Hellman (ECDH). - Provides a reference for secure key exchange and cryptographic operations with ECDH in OP-TEE. Signed-off-by: Amey Avinash Raghatate <[email protected]> State: waiting Link: linaro-swg#135
etienne-lms
reviewed
Oct 10, 2025
Contributor
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Sorry for the late feedback.
Update param type for the function cmd_ecdh_selftest. Update ecdh TA and Host as per review comments. Signed-off-by: Amey Avinash Raghatate <[email protected]>
Author
|
@etienne-lms could you please have a look at this. Thanks! |
etienne-lms
reviewed
Oct 21, 2025
Comment on lines
+33
to
+35
| #define ECDH_MAX_BITS 521 | ||
| #define ECDH_MAX_BYTES ((ECDH_MAX_BITS + 7) / 8) | ||
| #define ECDH_BUF_BYTES (ECDH_MAX_BYTES + 14) |
Contributor
There was a problem hiding this comment.
I think these 3 macros should not be part of the TA interface, to move to ecdh_ta.c.
They could but maybe specifying param[3].memref.buf recommended size is ECDH_BUF_BYTES but the TA API already allows CA to query the required size.
Why + 14?
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.