Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

Create a bagle wrapper model and a notebook that explains how this was done.

@jeremykubica jeremykubica requested a review from hombit November 25, 2025 14:00
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.58%. Comparing base (61da1b3) to head (c6abdfe).

Files with missing lines Patch % Lines
src/lightcurvelynx/models/bagle_models.py 92.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   94.60%   94.58%   -0.02%     
==========================================
  Files          62       63       +1     
  Lines        5431     5487      +56     
==========================================
+ Hits         5138     5190      +52     
- Misses        293      297       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Before [61da1b3] After [2cf2b26] Ratio Benchmark (Parameter)
128±6μs 132±6μs 1.03 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
29.8±0.4μs 30.6±0.7μs 1.03 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
99.7±2μs 101±2μs 1.02 benchmarks.TimeSuite.time_make_and_evaluate_step_model
47.7±0.9μs 48.4±0.8μs 1.02 benchmarks.TimeSuite.time_make_new_salt3_model
19.4±0.3ms 19.7±0.2ms 1.01 benchmarks.TimeSuite.time_chained_evaluate_sed
4.43±0.05ms 4.47±0.1ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_passbands
7.63±0.1ms 7.60±0.04ms 1 benchmarks.TimeSuite.time_apply_white_noise
719±40μs 712±30μs 0.99 benchmarks.TimeSuite.time_fnu_to_flam
6.79±0.04ms 6.72±0.08ms 0.99 benchmarks.TimeSuite.time_lightcurve_source
8.63±0.08ms 8.53±0.04ms 0.99 benchmarks.TimeSuite.time_load_passbands

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants