Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

For discussion

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.60%. Comparing base (6f72ab8) to head (0b0725a).

Files with missing lines Patch % Lines
src/lightcurvelynx/math_nodes/given_sampler.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files          62       62           
  Lines        5426     5431    +5     
=======================================
+ Hits         5133     5138    +5     
  Misses        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Before [6f72ab8] After [aa11161] Ratio Benchmark (Parameter)
133±9μs 120±3μs ~0.90 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
5.04±0.03ms 5.14±0.06ms 1.02 benchmarks.TimeSuite.time_lightcurve_source
104±1μs 106±2μs 1.02 benchmarks.TimeSuite.time_sample_x0_from_distmod
12.6±0.1μs 12.8±0.1μs 1.02 benchmarks.TimeSuite.time_sample_x1_from_hostmass
8.65±0.06ms 8.72±0.07ms 1.01 benchmarks.TimeSuite.time_load_passbands
49.2±0.4ms 49.0±0.4ms 1.00 benchmarks.TimeSuite.time_additive_multi_model_source
19.5±0.4ms 19.4±0.2ms 1.00 benchmarks.TimeSuite.time_chained_evaluate_sed
4.46±0.07ms 4.45±0.06ms 1.00 benchmarks.TimeSuite.time_evaluate_salt3_passbands
27.1±0.4ms 27.2±0.3ms 1.00 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
30.0±0.3μs 30.1±0.7μs 1.00 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants