Skip to content

Preparation for list-struct backend for NestedExtensionArray #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 22, 2025

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Apr 22, 2025

This PR adds a couple of helper functions to prepare a transition from struct-list chunked array to list-structure chunked array as the storage of NestedExtensionArray data.

@hombit hombit requested a review from dougbrn April 22, 2025 14:25
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (626718e) to head (5738621).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   98.17%   98.27%   +0.09%     
==========================================
  Files          14       14              
  Lines        1316     1331      +15     
==========================================
+ Hits         1292     1308      +16     
+ Misses         24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Apr 22, 2025

Before [626718e] After [344c4c3] Ratio Benchmark (Parameter)
35.7±5ms 42.7±8ms ~1.20 benchmarks.ReassignHalfOfNestedSeries.time_run
9.88±0.08ms 10.1±0.1ms 1.03 benchmarks.NestedFrameAddNested.time_run
25.0±1ms 25.2±0.6ms 1.01 benchmarks.AssignSingleDfToNestedSeries.time_run
10.8±0.07ms 10.9±0.05ms 1.01 benchmarks.NestedFrameQuery.time_run
1.30±0.04ms 1.31±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
274M 274M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
97M 97.2M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
101M 101M 1.00 benchmarks.NestedFrameQuery.peakmem_run
101M 101M 1.00 benchmarks.NestedFrameReduce.peakmem_run
293M 293M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@hombit
Copy link
Collaborator Author

hombit commented Apr 22, 2025

Commit list is way too long, I just wanted to take few changes from the previous implementation attempt.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one docs request

@hombit hombit enabled auto-merge (squash) April 22, 2025 17:28
@hombit hombit merged commit a96120e into main Apr 22, 2025
11 checks passed
@hombit hombit deleted the list-type-prep branch April 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants