[BUGFIX] "Home" link in the breadcrumb redirects to the "Services" page #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangpn
force-pushed
the
chores/fix_home_link_in_breadcrumb
branch
2 times, most recently
from
e0768bc to
bc21053
Compare
vincent-olivert-riera
requested changes
May 15, 2025
There was a problem hiding this comment.
Hello @hoangpn,
Your single commit is doing too many things. Basically, what you did is:
- Add the
v-pretag to thebreadcrumbtemplate tag - Add the
farmgenerator to thebreadcrumbtemplate tag - Reuse the
breadcrumbtemplate tag everywhere
Could you please split your changes in 3 separate commits?
You can use my list above for the commit message titles, and use your own words to explain the reason (and other details) on each commit message body.
We add the farm generator to the breadcrumb template tag to create breadcrumbs for pages associated with a Farm instance.
We included v-pre in the breadcrumb template tag to ensure that every breadcrumb generated by this template tag in Promgen contains the v-pre element.
We reuse the breadcrumb template tag everywhere to standardize the generation of a page's breadcrumb in Promgen. This also helps fix errors on some pages of Promgen that the Home link in the breadcrumb is redirected to the Services page instead of the Home page.
hoangpn
force-pushed
the
chores/fix_home_link_in_breadcrumb
branch
from
bc21053 to
2224c3b
Compare
vincent-olivert-riera
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some pages of Promgen, the Home link in the breadcrumb is redirected to the Services page instead of the Home page. We have fixed all these errors by using the "breadcrumb" template tag. We also made some improvements to this template tag to handle the Farm object and add the "v-pre" tag by default.