1st iteration fixes

[PavelLinearB]

✨ PR Description

Purpose: Implements a basic client-server chat system using socket programming and threading in Python.

Main changes:

• Created client.py with socket connection and message handling capabilities
• Implemented server.py with multi-client support using threaded connections
• Added data encoding/decoding for network communication between clients and server

Generated by LinearB AI and added by gitStream

[gitstream-cm]

✨ PR Review

Maintainability - src/server/server.py (Line 34-40)

Details:

Problem: Global connections list is modified without thread safety
Fix: Add mutex lock for connections list access
Why: Prevents race conditions when multiple threads modify the list

+ connection_lock = threading.Lock()

                print("Client " + str(self.address) + " has disconnected")
                self.signal = False
+               with connection_lock:
                    connections.remove(self)
                break

Performance - src/client/client.py & src/server/server.py (Line 10 & 33)

Details:

Problem: Fixed 32-byte buffer size limits message length and wastes bandwidth
Fix: Implement proper message framing with length prefix
Why: Allows variable length messages while maintaining efficiency

- data = socket.recv(32)
+ msg_size = int.from_bytes(socket.recv(4), 'big')
+ data = socket.recv(msg_size)

Potential Bug - src/client/client.py & src/server/server.py (Lines 9-14 & 32-37)

Details:

Problem: Bare except clauses mask important errors
Fix: Catch specific exceptions
Why: Allows proper handling of different error conditions

        try:
            data = socket.recv(32)
            print(str(data.decode('utf-8')))
-       except:
+       except (socket.error, ConnectionResetError) as e:
            print("You have been disconnected from the server")
            signal = False
            break

Generated by LinearB AI and added by gitStream

[vim-zz]

Suggested change

	#Get host and port
	host = input("Host: ")
	port = int(input("Port: "))
	#Get host and port
	host = input("Host: ");