-
Notifications
You must be signed in to change notification settings - Fork 5
✨ feat: implement note-taking feature on home page #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azigler
wants to merge
1
commit into
base-python
Choose a base branch
from
add-notes-handler-github
base: base-python
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| from django.db import models | ||
|
|
||
| # Create your models here. | ||
|
|
||
|
|
||
| def add_note(note, notes=[]): | ||
| """ | ||
| Adds a note to the notes list and returns the list. | ||
| """ | ||
| notes.append(note) | ||
| return notes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,16 @@ | ||
| from django.views.generic import TemplateView | ||
| from .models import add_note | ||
|
|
||
|
|
||
| class HomePageView(TemplateView): | ||
| template_name = "pages/home.html" | ||
|
|
||
| def get_context_data(self, **kwargs): | ||
| context = super().get_context_data(**kwargs) | ||
| notes = add_note("Visited home page") | ||
| context["notes"] = notes | ||
| return context | ||
|
|
||
|
|
||
| class AboutPageView(TemplateView): | ||
| template_name = "pages/about.html" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,21 @@ | ||
| {% extends '_base.html' %} | ||
| {% load static %} | ||
|
|
||
| {% block title %}Home page{% endblock title %} | ||
|
|
||
| {% block content %} | ||
| {% extends '_base.html' %} {% load static %} {% block title %}Home page{% | ||
| endblock title %} {% block content %} | ||
| <div class="pricing-header px-3 py-3 pt-md-5 pb-md-4 mx-auto text-center"> | ||
| <img src="{% static 'images/lithium.png' %}" class="img-fluid" alt="Lithium logo"/> | ||
| <img | ||
| src="{% static 'images/lithium.png' %}" | ||
| class="img-fluid" | ||
| alt="Lithium logo" | ||
| /> | ||
| <p class="lead">A Django starter project with batteries.</p> | ||
| </div> | ||
| {% endblock content %} | ||
|
|
||
| {% if notes %} | ||
| <div class="alert alert-info"> | ||
| <strong>Notes:</strong> | ||
| <ul> | ||
| {% for note in notes %} | ||
| <li>{{ note }}</li> | ||
| {% endfor %} | ||
| </ul> | ||
| </div> | ||
| {% endif %} {% endblock content %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a mutable default argument for 'notes' can lead to unexpected behavior as it retains state between function calls. Consider using 'None' as the default value and initializing a new list within the function.