-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Always display session/container name in isolation output #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #67
When using isolation backends (screen, docker, tmux), the output now shows the actual session/container name that users need to reconnect to sessions, especially in detached mode. Previously, only the session UUID was shown, but users need the actual backend name to: - Reconnect to detached screen sessions: `screen -r <name>` - Attach to tmux sessions: `tmux attach -t <name>` - View Docker container logs: `docker logs <name>` - Remove containers: `docker rm -f <name>` The fix ensures that the session name is always passed to the output formatting functions, regardless of whether it was explicitly provided via --session flag or auto-generated. Added tests to verify the fix and case study documentation. Fixes #67 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This reverts commit e1b5f26.
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
|
Also the same logic should be applied to Rust code. |
|
🤖 AI Work Session Started Starting automated work session at 2026-01-08T03:40:38.156Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait working session to finish, and provide your feedback. |
When using isolation backends (screen, docker, tmux), the Rust CLI now always displays the actual session/container name that users need to reconnect to sessions. Previously, the session name was only shown if explicitly provided via --session flag, but not when auto-generated. Changes: - rust/src/bin/main.rs: Always add session name to extraLines when using isolation - rust/src/lib/output_blocks.rs: Added comprehensive tests for issue #67 fix - rust/changelog.d/67.md: Changelog fragment for the fix - docs/case-studies/issue-67/ANALYSIS.md: Updated to include Rust implementation This allows users to: - Reconnect to detached screen sessions: screen -r <name> - Attach to tmux sessions: tmux attach -t <name> - View Docker container logs: docker logs <name> - Remove containers: docker rm -f <name> Fixes #67 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Apply rustfmt formatting to output_blocks.rs tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Summary
When using isolation backends (screen, docker, tmux), the output now shows the actual session/container name that users need to reconnect to sessions, especially in detached mode.
Before this fix:
After this fix:
This allows users to:
screen -r <name>tmux attach -t <name>docker logs <name>docker rm -f <name>Root Cause
The session name was only added to
extraLineswhen explicitly provided via--sessionflag, but not when auto-generated. The fix ensures the session name is always passed to output formatting.Changes
JavaScript Implementation
js/src/bin/cli.js: Always add session name to extraLines when using isolationjs/test/cli.test.js: Added tests for issue Make sure to also output session name and container name if they are not the same as main session uuid #67 fixjs/.changeset/issue-67-display-session-name.md: Changeset for releaseRust Implementation
rust/src/bin/main.rs: Always add session name to extraLines when using isolationrust/src/lib/output_blocks.rs: Added comprehensive tests for issue Make sure to also output session name and container name if they are not the same as main session uuid #67 fixrust/changelog.d/67.md: Changelog fragment for releaseDocumentation
docs/case-studies/issue-67/ANALYSIS.md: Updated with implementation details for both JS and RustTest Plan
Fixes #67
🤖 Generated with Claude Code