Skip to content

Conversation

@konard
Copy link
Member

@konard konard commented Jan 8, 2026

Summary

Fixes #73

The empty line in docker isolation output is now correctly placed AFTER the command line ($ docker pull alpine:latest) instead of BEFORE it, maintaining consistent visual structure in the timeline output.

Problem

When running $ --isolated docker -- echo 'hi', there was an empty line between the timeline marker () and the virtual command ($ docker pull):

│

$ docker pull alpine:latest
latest: Pulling from library/alpine

Solution

Move the empty line from before the command to after it:

│
$ docker pull alpine:latest

latest: Pulling from library/alpine

Changes

JavaScript:

  • cli.js: Skip empty line after start block when deferCommand is true
  • docker-utils.js: Add empty line after virtual command print, remove it before result marker

Rust:

  • main.rs: Skip println!() after start block when is_docker_isolation is true
  • isolation.rs: Add empty line after virtual command print, remove it before result marker

Tests:

  • Added visual continuity tests in both JS (output-blocks.test.js) and Rust (output_blocks_test.rs)

Test plan

  • Unit tests pass in JavaScript (bun test)
  • Unit tests pass in Rust (cargo test)
  • Linting passes (eslint, cargo clippy)
  • Formatting passes (prettier, cargo fmt)
  • CI passes

🤖 Generated with Claude Code

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #73
@konard konard self-assigned this Jan 8, 2026
The empty line is now correctly placed AFTER the command line
(e.g., `$ docker pull alpine:latest`) instead of BEFORE it,
maintaining consistent visual structure in the timeline output.

Changes:
- JS: Skip empty line after start block when deferCommand is true
- JS: Add empty line after virtual command, not before result marker
- Rust: Same changes for visual continuity
- Added tests for visual continuity behavior in both JS and Rust

Before:
```
│

$ docker pull alpine:latest
latest: Pulling from library/alpine
```

After:
```
│
$ docker pull alpine:latest

latest: Pulling from library/alpine
```

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@konard konard changed the title [WIP] Do not break visual continuity fix: Fix visual continuity in docker isolation mode Jan 8, 2026
@konard konard marked this pull request as ready for review January 8, 2026 18:38
@konard
Copy link
Member Author

konard commented Jan 8, 2026

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Public pricing estimate: $6.975038 USD
  • Calculated by Anthropic: $4.548152 USD
  • Difference: $-2.426886 (-34.79%)
    📎 Log file uploaded as GitHub Gist (1270KB)
    🔗 View complete solution draft log

Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard konard merged commit 3ff5b1c into main Jan 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not break visual continuity

2 participants