fix: Fix visual continuity in docker isolation mode #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #73
The empty line in docker isolation output is now correctly placed AFTER the command line (
$ docker pull alpine:latest) instead of BEFORE it, maintaining consistent visual structure in the timeline output.Problem
When running
$ --isolated docker -- echo 'hi', there was an empty line between the timeline marker (│) and the virtual command ($ docker pull):Solution
Move the empty line from before the command to after it:
Changes
JavaScript:
cli.js: Skip empty line after start block whendeferCommandis truedocker-utils.js: Add empty line after virtual command print, remove it before result markerRust:
main.rs: Skipprintln!()after start block whenis_docker_isolationis trueisolation.rs: Add empty line after virtual command print, remove it before result markerTests:
output-blocks.test.js) and Rust (output_blocks_test.rs)Test plan
bun test)cargo test)eslint,cargo clippy)prettier,cargo fmt)🤖 Generated with Claude Code