Fixed possible range mutation of the same attribute #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UITextView
can split anNSAttributedString
and set newfont
attribute if some substring has a different language which needs another font (for example when the mention include both English and Korean, the Korean substring will have anotherfont
attribute then the default one set to thatUITextView
).After the "split", each substring still had the same pointer to the same
HKWMentionsAttribute
, which repeatedly changed itsrange
to the latest, and then made thebuffer
include the sameHKWMentionsAttribute
pointer multiple times and prevented access to all mention attributes.Here I just created a new attribute and set the range to it, so at least we can iterate all ranges and decide if we want to merge or not, depending on the use case.