Skip to content

Do not mock ByteBuffer in unit tests #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izzytwosheds merged 5 commits into from
Nov 19, 2025
Merged

Do not mock ByteBuffer in unit tests #284

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c7a565
Bump actions/cache to 4.2.0
izzytwosheds Nov 18, 2025
b9b6ce5
Bump actions/cache to 4.2.0
izzytwosheds Nov 18, 2025
c1ce168
Bump cmake to 4.1.2
izzytwosheds Nov 18, 2025
fd05379
Merge branch 'linkedin:main' into main
izzytwosheds Nov 18, 2025
e782e5e
Fix PassthroughTranscoder unit test failure
izzytwosheds Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions litr/src/test/java/com/linkedin/android/litr/transcoder/PassthroughTranscoderShould.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@ public class PassthroughTranscoderShould {
private static final long SAMPLE_TIME = 21;
private static final int BUFFER_SIZE = 512;

private final ByteBuffer outputBuffer = ByteBuffer.allocate(1);

private static final long CURRENT_PRESENTATION_TIME = 42;
private static final long SELECTION_START = 16;
private static final long SELECTION_END = 64;

@Mock private MediaSource mediaSource;
@Mock private MediaTarget mediaTarget;
@Mock private MediaCodec.BufferInfo outputBufferInfo;
@Mock private ByteBuffer outputBuffer;

@Mock private MediaFormat sourceMediaFormat;

Expand All @@ -59,7 +60,7 @@ public class PassthroughTranscoderShould {

@Before
public void setup() throws Exception {
MockitoAnnotations.initMocks(this);
MockitoAnnotations.openMocks(this);

fullMediaRange = new MediaRange(0, Long.MAX_VALUE);
trimmedMediaRange = new MediaRange(SELECTION_START, SELECTION_END);
Expand Down
Loading