Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that under some scenario stop_proposal_execution does not take effect #270

Closed
wants to merge 1 commit into from

Conversation

kidkun
Copy link

@kidkun kidkun commented Jun 27, 2018

fix for ticket
#184
Instead of canceling an ongoing analyzer process, the patch let the analyzer process finish but does not execute the proposal. The client will still get anticipated result of execution(just like set dryrun=true).

Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.
The issue #184 is about enabling cancellation of an ongoing goal optimization, whereas this patch does not cancel once a thread is in the process of optimizing goals. Goal optimization is an expensive operation of the Analyzer module -- this is what we would like to cancel.

Moreover, setting _stopRequested.set(false); via the proposed ready() call would potentially prevent a user's stopExecution to take effect (please note the race condition when there is an ongoing execution, the user calls stop execution, then a second user calls any execution operation such as demote).

@kidkun
Copy link
Author

kidkun commented Sep 10, 2018

close this one for now, plan to have a more comprehensive solution after the UUID feature get brought in(to have a better way to track the ongoing jobs).

@kidkun kidkun closed this Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants