Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEAD requests content-length is not based on the body as per the http spec. #901

Merged
merged 1 commit into from
May 11, 2023

Conversation

jpstewart
Copy link
Contributor

Fixing it to not override the content-length if the request is HEADER type.

This is resubmission of a previous PR #896

@jpstewart jpstewart requested review from bohhyang and gu0keno0 May 2, 2023 22:13
@jpstewart jpstewart force-pushed the header-content-length-fix-jostewar branch from d0d4293 to 4bb833d Compare May 10, 2023 16:20
@jpstewart jpstewart requested review from nizarm, rickzx and evanw555 May 10, 2023 17:06
Copy link
Contributor

@nizarm nizarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we do a wc-test as per the pegasus release protocol? If yes, please feel free to merge this and release a version for espresso.

@jpstewart jpstewart force-pushed the header-content-length-fix-jostewar branch from 4bb833d to bec1a8b Compare May 11, 2023 19:13
@jpstewart jpstewart temporarily deployed to jfrog-publish May 11, 2023 19:17 — with GitHub Actions Inactive
… spec.

Fixing it to not override the content-length if the request is HEADER type.
@jpstewart jpstewart force-pushed the header-content-length-fix-jostewar branch from bec1a8b to 4671c3d Compare May 11, 2023 22:38
@jpstewart jpstewart merged commit da4caef into master May 11, 2023
@jpstewart jpstewart deleted the header-content-length-fix-jostewar branch May 11, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants