Skip to content

Poetry 2 compatibility #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dalito wants to merge 2 commits into from
Closed

Poetry 2 compatibility #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68749f2
Remove old poetry pins, make pyproject poetry 2.0 compatible
dalito Jan 28, 2025
22a46a4
Update of poetry lock file
dalito Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/check-dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ jobs:
# install poetry
#----------------------------------------------
- name: Install Poetry
# Pin to 1.3.2 to workaround https://github.com/python-poetry/poetry/issues/7611
run: pipx install poetry==1.3.2
run: pipx install poetry

#----------------------------------------------
# check-out repo and set-up python
Expand All @@ -45,7 +44,7 @@ jobs:
# install your root project, if required
#----------------------------------------------
- name: Install library
run: poetry install --no-interaction
run: poetry install --no-interaction --all-groups

# this step we remove and rebuild the poetry.lock file to ensure that the tests that follow can be run
# with the latest dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
# install poetry
#----------------------------------------------
- name: Install Poetry
run: pipx install poetry==1.4.0
run: pipx install poetry

#----------------------------------------------
# check-out repo and set-up python
Expand All @@ -43,7 +43,7 @@ jobs:
# install your root project, if required
#----------------------------------------------
- name: Install library
run: poetry install --no-interaction
run: poetry install --no-interaction --with dev

#----------------------------------------------
# coverage report
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-upstream.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install poetry
run: pipx install poetry
# Pin to 1.8.5. because Poetry 2.0.0 installs plugins in a different way
# (dynamic versioning in next step)
run: pipx install poetry==1.8.5
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a way to pin a specific version of poetry in pyproject.toml https://python-poetry.org/blog/announcing-poetry-2.0.0/

We may want to do a quick 1-line PR to upstream linkml to add this pin there rather than here so they don't go out of sync & fix later, but since this is likely to be a quick and easy change to both packages not necessary at all and this would be fine too

Copy link
Member Author

@dalito dalito Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the option to constrain poetry was added only in 2.0 - I could not find it in 1.8.5.


- name: Install dynamic versioning plugin
run: poetry self add "poetry-dynamic-versioning[plugin]"
Expand Down
Loading
Loading