Skip to content

SchemaView: format, lint autofix, add typing + docs #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

SchemaView: format, lint autofix, add typing + docs #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
556b035
Use specific imports from linkml_runtime.linkml_model.meta rather tha…
ialarmedalien May 6, 2025
ef9b902
Run ruff check --fix to fix simple linter errors
ialarmedalien May 6, 2025
c7e1c3a
Adding typing and basic docstring where missing
ialarmedalien May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions linkml_runtime/dumpers/rdflib_dumper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@


from linkml_runtime.dumpers.dumper_root import Dumper
from linkml_runtime.linkml_model import SlotDefinition
from linkml_runtime.utils.schemaview import SchemaView, ElementName, PermissibleValue, PermissibleValueText
from linkml_runtime.linkml_model import ElementName, PermissibleValue, PermissibleValueText, SlotDefinition
from linkml_runtime.utils.schemaview import SchemaView
from linkml_runtime.utils.yamlutils import YAMLRoot

logger = logging.getLogger(__name__)
Expand Down
2 changes: 1 addition & 1 deletion linkml_runtime/index/object_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from typing import Any, Union
from collections.abc import Mapping, Iterator

from linkml_runtime import SchemaView
from linkml_runtime.utils.schemaview import SchemaView
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use full path for import (this was mostly to make it easier for me to find places where weird stuff was being imported from SchemaView)

from linkml_runtime.utils import eval_utils
from linkml_runtime.utils.yamlutils import YAMLRoot

Expand Down
12 changes: 9 additions & 3 deletions linkml_runtime/loaders/rdflib_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@
from rdflib.term import BNode, Literal
from rdflib.namespace import RDF

from linkml_runtime import MappingError, DataNotFoundError
from linkml_runtime.linkml_model import ClassDefinitionName, TypeDefinition, EnumDefinition, ClassDefinition
from linkml_runtime import DataNotFoundError, MappingError
from linkml_runtime.linkml_model import (
ClassDefinition,
ClassDefinitionName,
EnumDefinition,
SlotDefinition,
TypeDefinition,
)
from linkml_runtime.loaders.loader_root import Loader
from linkml_runtime.utils.formatutils import underscore
from linkml_runtime.utils.schemaview import SchemaView, SlotDefinition
from linkml_runtime.utils.schemaview import SchemaView
from linkml_runtime.utils.yamlutils import YAMLRoot
from pydantic import BaseModel

Expand Down
2 changes: 1 addition & 1 deletion linkml_runtime/processing/referencevalidator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import click
import yaml

from linkml_runtime import SchemaView
from linkml_runtime.utils.schemaview import SchemaView
from linkml_runtime.dumpers import yaml_dumper
from linkml_runtime.linkml_model import (
SlotDefinition,
Expand Down
2 changes: 1 addition & 1 deletion linkml_runtime/utils/inference_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import Union, Optional, Any, Callable
from jsonasobj2 import JsonObj, items

from linkml_runtime import SchemaView
from linkml_runtime.utils.schemaview import SchemaView
from linkml_runtime.linkml_model import SlotDefinitionName, PermissibleValue, ClassDefinitionName
from linkml_runtime.utils.enumerations import EnumDefinitionImpl
from linkml_runtime.utils.eval_utils import eval_expr
Expand Down
Loading
Loading