Add family name support to user display in top and reputation change #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #20
* Add get_user_full_name method to Bot class to retrieve both first and last names from VK API * Update user creation in BetterBotBaseDataService to store full names (first + last) * Update user profile updates to use full names * Update karma change messages to display full names instead of just first names * Update VkInstance mock class to support get_user_full_name method * Top user listings now show full names in format: [id123|John Smith] instead of [id123|John] * Reputation/karma change notifications now display full names for better user identification Fixes #20 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
get_user_full_name()method to Bot class that retrieves both first and last names from VK APIBetterBotBaseDataService.get_or_create_user()to store full names (first + last) instead of just first namesupdate_command()to use full names when updating user profilesget_user_full_name()method to VkInstance mock for testingBefore vs After
Before:
[id123|John] - github.com/john Python, JavaScriptКарма изменена: [id123|John] [5]->[6]After:
[id123|John Smith] - github.com/john Python, JavaScriptКарма изменена: [id123|John Smith] [5]->[6]Test Plan
🤖 Generated with Claude Code
Resolves #20