Rename C++ ThrowExtensions to ExceptionFactory to reflect actual behavior #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ThrowExtensions.htoExceptionFactory.hin the C++ implementationBackground
The issue was that the C++
ThrowExtensions.hfile contains functions that return exception objects (likestd::logic_error) rather than throwing them, making the name misleading:These are used with
throwby calling code:The C# version correctly uses the name
ThrowExtensionsbecause those methods actually do throw exceptions.Changes Made
cpp/Platform.Exceptions/ThrowExtensions.h→cpp/Platform.Exceptions/ExceptionFactory.hPlatform.Exceptions.h.vcxprojand.vcxproj.filters)Test Plan
Fixes #76
🤖 Generated with Claude Code