Use safe specialization for C++ functors #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #63
Replace unsafe std namespace specializations with safe template
specialization syntax:
- Changed from 'namespace std { template<...> struct hash<Type> {...} }'
- To 'template<...> struct std::hash<Type> {...}'
This addresses issue #63 by using the safer approach that avoids
namespace pollution and ADL issues.
Changes made in both C# and Python implementations:
- CSharpToCppTransformer.cs: Updated regex to generate safe syntax
- cs2cpp.py: Updated SubRule to generate safe syntax
- Added test case to verify the transformation works correctly
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the requested changes from issue #63 to use safe specialization for C++ functors.
Changes made:
namespace std { ... }syntax with safe template specializationtemplate<...> struct std::hash<Type> { ... }CSharpToCppTransformer.cs) and Python (cs2cpp.py) implementationsBefore (unsafe):
After (safe):
template<...> std::hash<Type<...>> { }Test plan
The safe specialization approach avoids namespace pollution and potential ADL (Argument-Dependent Lookup) issues while maintaining full functionality.
🤖 Generated with Claude Code
Resolves #63