Remove ConcurrentQueueExtensions - promotes worse async patterns than Task.WaitAll #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
ConcurrentQueueExtensions
as it promotes worse async design patterns compared to the standard .NETTask.WaitAll
method.Problem with Current Implementation
The
ConcurrentQueueExtensions.AwaitAll()
method has a fundamental flaw:Issue: This awaits tasks sequentially, not in parallel. If you have 3 tasks that each take 100ms, the total time will be ~300ms instead of ~100ms.
Why Task.WaitAll is Superior
Changes Made
csharp/Platform.Threading/ConcurrentQueueExtensions.cs
cpp/Platform.Threading/ConcurrentQueueExtensions.h
ConcurrentQueueExtensions
referencesnet8
for consistencyMigration Path
Instead of:
Use standard .NET pattern:
Test Plan
ConcurrentQueueExtensions
in codebaseFixes #25
🤖 Generated with Claude Code