Skip to content

Conversation

konard
Copy link
Member

@konard konard commented Sep 14, 2025

Summary

This PR fixes the DocFX documentation generation issue described in #11 where XML <include> tags were failing to inherit documentation comments from the ISynchronization interface.

Changes Made

  • Removed problematic XML include tags from ReaderWriterLockSynchronization.cs and Unsynchronization.cs
  • Replaced with <inheritdoc/> tags to properly inherit documentation from the ISynchronization interface
  • Verified build and tests pass with the changes

Root Cause

The issue was caused by XML <include> tags referencing non-existent build artifacts:

<include file='bin\Release\netstandard2.0\Platform.Threading.xml' path='doc/members/member[@name="..."]/*'/>

These tags were pointing to XML files that don't exist in the repository, causing DocFX to fail when trying to process the documentation.

Solution

Since both ReaderWriterLockSynchronization and Unsynchronization classes implement the ISynchronization interface, which already contains comprehensive XML documentation, using <inheritdoc/> is the proper solution. This allows DocFX to correctly inherit and display the documentation from the interface.

Testing

  • ✅ Project builds successfully (dotnet build -c Release)
  • ✅ All tests pass (dotnet test -c Release)
  • ✅ No more XML include tag references in the codebase

Fixes #11

🤖 Generated with Claude Code

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #11
@konard konard self-assigned this Sep 14, 2025
Remove problematic XML include tags that reference non-existent build artifacts and replace them with inheritdoc tags. This resolves the DocFX documentation generation issue where include tags were failing to inherit XML documentation comments from the ISynchronization interface.

Changes:
- Replace include tags with inheritdoc in ReaderWriterLockSynchronization.cs
- Replace include tags with inheritdoc in Unsynchronization.cs
- Documentation now properly inherits from ISynchronization interface

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@konard konard changed the title [WIP] DocFX failed to inherit XML documentation comments Fix DocFX XML documentation include tags (Issue #11) Sep 14, 2025
@konard konard marked this pull request as ready for review September 14, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DocFX failed to inherit XML documentation comments

1 participant