Skip to content

Conversation

jriddle-linode
Copy link
Collaborator

📝 Description

What does this PR do and why is this change necessary?

Adds module for handling GET and PUT for account/settings

✔️ How to Test

How do I run the relevant unit/integration tests?

make test-int TEST_SUITE=account_settings

@jriddle-linode jriddle-linode requested a review from a team as a code owner June 17, 2025 15:41
@jriddle-linode jriddle-linode requested review from ezilber-akamai and lgarber-akamai and removed request for a team June 17, 2025 15:41
@lgarber-akamai
Copy link
Contributor

@jriddle-linode This look great and should be good to go as soon as CI is passing.

Side note: Would it make sense to disable the new test in CI to prevent a potential race condition for concurrent test runs? The always logic works great for synchronous local testing but might cause some issues on our test accounts

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"longview_subscription": "longview-3",
"managed": true,
"network_helper": false,
"object_storage": "active",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jriddle-linode When you have a chance, could you make this change and re-render the docs to fix the CI?

Suggested change
"object_storage": "active",
"object_storage": "active"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants