Make Image field optional for LMT

api/v1alpha2/linodemachine_types.go

@@ -82,7 +82,6 @@ type LinodeMachineSpec struct {
 
 	// image is the Linode image to use for the instance.
 	// +optional
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	Image string `json:"image,omitempty"`
 
 	// interfaces is a list of legacy network interfaces to use for the instance.

config/crd/bases/infrastructure.cluster.x-k8s.io_linodemachines.yaml

@@ -414,9 +414,6 @@ spec:
               image:
                 description: image is the Linode image to use for the instance.
                 type: string
-                x-kubernetes-validations:
-                - message: Value is immutable
-                  rule: self == oldSelf
               instanceID:
                 description: instanceID is the Linode instance ID for this machine.
                 type: integer

config/crd/bases/infrastructure.cluster.x-k8s.io_linodemachinetemplates.yaml

@@ -417,9 +417,6 @@ spec:
                       image:
                         description: image is the Linode image to use for the instance.
                         type: string
-                        x-kubernetes-validations:
-                        - message: Value is immutable
-                          rule: self == oldSelf
                       instanceID:
                         description: instanceID is the Linode instance ID for this
                           machine.

internal/webhook/v1alpha2/linodemachine_webhook.go

@@ -88,6 +88,20 @@ func (r *linodeMachineValidator) ValidateUpdate(ctx context.Context, oldObj, new
 	}
 	linodemachinelog.Info("validate update", "name", old.Name)
 
+	newMachine, ok := newObj.(*infrav1alpha2.LinodeMachine)
+	if !ok {
+		return nil, apierrors.NewBadRequest("expected a LinodeMachine Resource")
+	}
+
+	// ensure that spec.Image is immutable
+	if old.Spec.Image != newMachine.Spec.Image {
+		return nil, &field.Error{
+			Field:  "spec.image",
+			Type:   field.ErrorTypeInvalid,
+			Detail: "Field is immutable",
+		}
+	}
+
 	// TODO(user): fill in your validation logic upon object update.
 	return nil, nil
 }