Add compatibility with OSX #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hmm. Should we make it detect the OS, so if it is Mac OS X and gnu-sed isn't installed then the script won't proceed further? |
Contributor
Author
|
Hmm we could do, makes sense (have it just print out 1-2 lines of instructions for installing gnu-sed and exit). I'll let you know once I've added that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sedon OSX isn't a gnu-style sed, so things break everywhere. If you installgnu-sedfrom Homebrew and then usegsedinstead ofsedin the script, it works fine.This uses
gsedif it's available, and otherwise usessed.