Improve spaces handling in driver names #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the intermediate "cmd" argument so that spaces in passed arguments are preserved. Signed-off-by: Elliot Berman <[email protected]>
`cd ${dev}` prevents drivers (or devices) with spaces in their names
from being cd'd to. Add quotes to allow spaces in the driver names.
Signed-off-by: Elliot Berman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running bootrr for a board that has spaces in the driver name, and I get the following complaints:
The driver name in this case is "bar baz".
Further, the rule generator is unhappy trying to
cd /sys/bus/foo/drivers/bar baz/qux.