feat: add support for reverting LV back to state of snapshot #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
reviewed
Jan 25, 2024
richm
reviewed
Jan 25, 2024
Reason: MVP requirements call for ability to revert snapshots Use the lvconvert --merge command to revert the changes made to the LVM logical volume. If either the source LV or snapshot are open, the merge is deferred until the next time the server reboots and thesource logical volume is activated. Refactor command line parser to simplify. Result: Users can revert to snapshots Signed-off-by: Todd Gill <[email protected]> Co-authored-by: Richard Megginson <[email protected]>
|
[citest] |
richm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: add support for reverting LVs to snapshots
Reason: MVP requirements call for ability to revert snapshots
Use the lvconvert --merge command to revert the changes made to the
LVM logical volume.
If either the source LV or snapshot are open, the merge is deferred
until the next time the server reboots and thesource logical volume
is activated.
Result: Users can revert to snapshots
Issue Tracker Tickets (Jira or BZ if any):