libusbgx: fix bMaxPower handling #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libusbgx expects the maximum power consumption value to be specified in 2mA units, but the kernel takes the "real" mA value and does the conversion to 2mA units when constructing the High Speed descriptors. Convert the value to and from the expected format when reading from or writing to configfs. This is sufficient for High Speed devices where the maximum possible current draw is 500mA, but still does not permit SuperSpeed or faster devices advertising current draw up to 900mA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libusbgx expects the maximum power consumption value to be specified in 2mA units, but the kernel takes the "real" mA value and does the conversion to 2mA units when constructing the High Speed descriptors.
Convert the value to and from the expected format when reading from or writing to configfs.
This is sufficient for High Speed devices where the maximum possible current draw is 500mA, but still does not permit SuperSpeed or faster devices advertising current draw up to 900mA.