Skip to content

Conversation

@wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 20, 2025

as title.

PMS-BUG-281483

Summary by Sourcery

Bug Fixes:

  • Remove condition that treated matching desktop and autostart file paths as an indication of auto-start.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 删除了检查 m_autostartSource.m_filePath 是否等于 m_desktopSource.sourcePath() 的代码,可能会影响 isAutoStart 方法的逻辑。

是否建议立即修改:

  • 是,需要确认删除这段代码的原因,并确保不会对 isAutoStart 方法的功能产生负面影响。如果这段代码是有意删除的,应该添加相应的注释说明为什么这样做。如果这段代码是无意的删除,应该恢复这段代码。

@sourcery-ai
Copy link

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

Removed outdated autostart detection logic in ApplicationService::isAutoStart to prevent non-autostart apps from being marked as auto-start after reboot.

Updated Class Diagram for ApplicationService

classDiagram
    class ApplicationService {
        +isAutoStart() bool
    }
Loading

File-Level Changes

Change Details Files
Removed incorrect file-path comparison that forced apps into autostart state
  • Deleted condition checking if autostart source path equals desktop source path
  • Removed early return true for matching file paths
src/dbus/applicationservice.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 2bf7325 into linuxdeepin:master Jun 3, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants