Support Splash

[wineee]

Summary by Sourcery

Add Wayland-based prelaunch splash support to the application manager and wire it into app launches.

New Features:

• Show a compositor-driven prelaunch splash screen for applications when running under Wayland, using app IDs and icons.
• Introduce a PrelaunchSplashHelper Wayland client extension to communicate with the treeland-prelaunch-splash protocol and construct icon buffers from application icons.

Enhancements:

• Initialize and expose a splash helper in ApplicationManager1Service only when running under Wayland, with structured logging for splash lifecycle.
• Convert the application manager process to use QGuiApplication instead of QCoreApplication to support Wayland/GUI integration.

Build:

• Generate Wayland client sources for the treeland-prelaunch-splash-v1 protocol and link against Qt Wayland client libraries, including private headers.
• Update top-level, dbus, app, and test CMake configurations to include Wayland, GUI, and generated header include paths, and depend on TreelandProtocols.

[deepin-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sourcery-ai]

Reviewer's Guide

Adds a Wayland-based prelaunch splash mechanism wired into application launch, introduces a PrelaunchSplashHelper Wayland client extension, switches the application manager to QGuiApplication, and updates CMake/test configuration to generate/link Wayland client protocol code and expose needed headers.

Sequence diagram for application launch with prelaunch splash on Wayland

sequenceDiagram
    actor User
    participant ClientApp
    participant DBus as ApplicationManager1DBus
    participant AM1 as ApplicationManager1Service
    participant AS as ApplicationService
    participant Splash as PrelaunchSplashHelper
    participant Compositor as WaylandCompositor

    User->>ClientApp: Request application launch
    ClientApp->>DBus: org.desktopspec.ApplicationManager1.Launch
    DBus->>AM1: Launch call dispatched
    AM1->>AS: Create or reuse ApplicationService for appId
    AM1-->>DBus: Return pending call handle

    AS->>AS: Parse launch options and desktop entry
    AS->>AM1: parent()
    AS->>AM1: splashHelper()
    AM1-->>AS: PrelaunchSplashHelper pointer or null

    alt Helper available (Wayland session)
        AS->>AS: findEntryValue(Icon)
        AS->>Splash: show(appId, iconName)
        Splash->>Splash: buildIconBuffer(icon)
        Splash->>Compositor: create_splash(appId, dde-application-manager, wl_buffer)
        Compositor-->>Splash: Ack splash creation
    else No helper (non-Wayland or init failed)
        AS->>AS: Log skip prelaunch splash
    end

    AS->>AS: Complete launch preparation
    AS->>System: Spawn application process
    System-->>AS: Application started
    AS-->>DBus: Return launch result

Loading

Class diagram for PrelaunchSplashHelper and application manager integration

classDiagram
    class ApplicationManager1Service {
        - std::unique_ptr~Identifier~ m_identifier
        - std::unique_ptr~Storage~ m_storage
        - QTimer m_reloadTimer
        - QHash~QString, QSharedPointer~ApplicationService~~ m_applicationList
        - QSharedPointer~CompatibilityManager~ m_compatibilityManager
        - QScopedPointer~PrelaunchSplashHelper~ m_splashHelper
        + ApplicationManager1Service(std::unique_ptr~Identifier~ ptr, std::unique_ptr~Storage~ storage)
        + const MimeManager1Service & mimeManager() const
        + const QStringList & systemdPathEnv() const
        + QSharedPointer~CompatibilityManager~ getCompatibilityManager() const
        + PrelaunchSplashHelper * splashHelper() const
    }

    class ApplicationService {
        + QString Launch(QString action, QStringList fields, QVariantMap optionsMap)
        + QString id() const
        + ApplicationManager1Service * parent() const
    }

    class PrelaunchSplashHelper {
        <<QObject>>
        <<QWaylandClientExtensionTemplate_PrelaunchSplashHelper>>
        <<treeland_prelaunch_splash_manager_v1>>
        - std::unique_ptr~Impl~ m_impl
        + PrelaunchSplashHelper()
        + ~PrelaunchSplashHelper()
        + void show(QString appId, QString iconName)
        - wl_buffer * buildIconBuffer(QIcon icon)
        - wl_buffer * createBufferFromPixmap(QPixmap pixmap)
    }

    class PrelaunchSplashHelper_Impl {
        + std::vector~std::unique_ptr~QtWaylandClient_QWaylandShmBuffer~~ iconBuffers
    }

    class QtWaylandClient_QWaylandShmBuffer {
        + QWaylandClient_QWaylandShmBuffer(QWaylandDisplay display, QSize size, QImage_Format format, qreal devicePixelRatio)
        + QImage * image()
        + wl_buffer * buffer()
    }

    class QGuiApplication {
        + static QCoreApplication * instance()
        + template QNativeInterface_QWaylandApplication * nativeInterface()
    }

    class QWaylandIntegration {
        + QWaylandDisplay * display()
    }

    class QWaylandDisplay

    class treeland_prelaunch_splash_manager_v1 {
        + void create_splash(QString appId, QString launcherId, wl_buffer * buffer)
    }

    ApplicationManager1Service --> ApplicationService : owns
    ApplicationManager1Service --> PrelaunchSplashHelper : m_splashHelper
    ApplicationService --> ApplicationManager1Service : parent()
    ApplicationService --> PrelaunchSplashHelper : show(appId, iconName)
    PrelaunchSplashHelper --> PrelaunchSplashHelper_Impl : uses
    PrelaunchSplashHelper_Impl --> QtWaylandClient_QWaylandShmBuffer : iconBuffers
    PrelaunchSplashHelper --> QtWaylandClient_QWaylandShmBuffer : createBufferFromPixmap
    PrelaunchSplashHelper --> treeland_prelaunch_splash_manager_v1 : create_splash
    PrelaunchSplashHelper --> QGuiApplication : uses instance
    PrelaunchSplashHelper --> QWaylandIntegration : integration()
    QWaylandIntegration --> QWaylandDisplay : display()

Loading

File-Level Changes

Change	Details	Files
Initialize and expose a Wayland prelaunch splash helper in the application manager service only when running under Wayland, with logging.	Include QGuiApplication, QLoggingCategory, and PrelaunchSplashHelper in the service implementation and header. Detect Wayland runtime via QGuiApplication and QNativeInterface::QWaylandApplication in the ApplicationManager1Service constructor. Allocate and own a QScopedPointer when on Wayland, with qCInfo/qCWarning logging on success/failure or skipping. Expose a splashHelper() accessor returning the helper pointer.	src/dbus/applicationmanager1service.cpp src/dbus/applicationmanager1service.h
Trigger a prelaunch splash request to the compositor as part of application launch when a splash helper is available.	Include PrelaunchSplashHelper and QLoggingCategory in ApplicationService. During Launch, obtain the parent ApplicationManager1Service and its splashHelper(). Extract the desktop file Icon entry, derive an icon name string, and log a splash request with app id and icon. Call helper->show(id(), iconName) when a helper exists, or log that the splash is skipped when there is no helper or no parent service.	src/dbus/applicationservice.cpp
Implement the PrelaunchSplashHelper Wayland client extension that converts QIcons into wl_buffer-backed shm buffers and sends treeland prelaunch splash requests.	Declare PrelaunchSplashHelper as a QWaylandClientExtensionTemplate and treeland_prelaunch_splash_manager_v1 subclass, with a private Impl storing QWaylandShmBuffer ownership. Register a logging category amPrelaunchSplash. Implement show(appId, iconName) to check extension activation, clear previous buffers, resolve the icon (theme/path), build a wl_buffer from it, and call create_splash with the app id, fixed client id, and optional buffer, logging success/skip paths. Provide helper methods buildIconBuffer and createBufferFromPixmap that pick an appropriate icon size, create a QWaylandShmBuffer via the Wayland integration/display, paint the icon centered into the buffer image, retain the buffer in Impl to keep it alive, and return the wl_buffer.	src/dbus/prelaunchsplashhelper.cpp src/dbus/prelaunchsplashhelper.h
Switch the application manager process to use QGuiApplication so Wayland and GUI-related APIs are available.	Replace QCoreApplication with QGuiApplication in main.cpp, including headers and type names. Update the event loop startup to call QGuiApplication::exec(). Link the dde-application-manager executable against Qt6::Gui.	apps/dde-application-manager/src/main.cpp apps/dde-application-manager/src/CMakeLists.txt
Extend CMake configuration to integrate Treeland prelaunch splash protocol generation, Wayland client libraries, and necessary include paths for dbus and tests.	Add Qt6 WaylandClient and Gui to the top-level Qt6 find_package call and require TreelandProtocols. Generate Wayland client sources for treeland-prelaunch-splash-v1.xml in the dbus CMakeLists using qt_generate_wayland_protocol_client_sources. Link dde_am_dbus against Qt WaylandClient and WaylandClientPrivate and expose their private include directories plus the current binary dir as public includes. Expose ${PROJECT_BINARY_DIR}/src/dbus to the tests target so it can include generated dbus headers.	CMakeLists.txt src/dbus/CMakeLists.txt tests/CMakeLists.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-bot]

TAG Bot

New tag: 1.2.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #303

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• In src/dbus/CMakeLists.txt, consider making the WaylandClientPrivate include directories target-private instead of adding $<TARGET_PROPERTY:Qt${QT_VERSION_MAJOR}::WaylandClientPrivate,INTERFACE_INCLUDE_DIRECTORIES> to dde_am_dbus's PUBLIC include dirs, to avoid leaking Qt private headers into dependents and tightening the coupling to Qt internals.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `src/dbus/CMakeLists.txt`, consider making the WaylandClientPrivate include directories target-private instead of adding `$<TARGET_PROPERTY:Qt${QT_VERSION_MAJOR}::WaylandClientPrivate,INTERFACE_INCLUDE_DIRECTORIES>` to `dde_am_dbus`'s PUBLIC include dirs, to avoid leaking Qt private headers into dependents and tightening the coupling to Qt internals.

## Individual Comments

### Comment 1
<location> `src/dbus/prelaunchsplashhelper.h:36` </location>
<code_context>
+private:
+    wl_buffer *buildIconBuffer(const QIcon &icon);
+    wl_buffer *createBufferFromPixmap(const QPixmap &pixmap);
+    struct Impl;
+    std::unique_ptr<Impl> m_impl;
+};
</code_context>

<issue_to_address>
**issue (complexity):** Consider removing the PIMPL indirection and store the icon buffers directly in PrelaunchSplashHelper to simplify the class structure and reduce overhead.

The PIMPL here adds an extra allocation/indirection without a clear benefit given this helper is already tied to Wayland internals and (per the other review) only stores the icon buffers. You can simplify and reduce complexity/overhead by inlining the state directly in the class.

For example, instead of:

```cpp
class PrelaunchSplashHelper
    : public QWaylandClientExtensionTemplate<PrelaunchSplashHelper>
    , public QtWayland::treeland_prelaunch_splash_manager_v1
{
    Q_OBJECT
public:
    explicit PrelaunchSplashHelper();
    ~PrelaunchSplashHelper();
    void show(const QString &appId, const QString &iconName);

private:
    wl_buffer *buildIconBuffer(const QIcon &icon);
    wl_buffer *createBufferFromPixmap(const QPixmap &pixmap);

    struct Impl;
    std::unique_ptr<Impl> m_impl;
};
```

you can hold the buffers directly:

```cpp
class PrelaunchSplashHelper
    : public QWaylandClientExtensionTemplate<PrelaunchSplashHelper>
    , public QtWayland::treeland_prelaunch_splash_manager_v1
{
    Q_OBJECT
public:
    explicit PrelaunchSplashHelper();
    ~PrelaunchSplashHelper();
    void show(const QString &appId, const QString &iconName);

private:
    wl_buffer *buildIconBuffer(const QIcon &icon);
    wl_buffer *createBufferFromPixmap(const QPixmap &pixmap);

    std::vector<std::unique_ptr<QtWaylandClient::QWaylandShmBuffer>> m_iconBuffers;
};
```

And in the `.cpp`, move any logic from `Impl` methods into `PrelaunchSplashHelper` methods, and replace `m_impl->buffers` (or similar) with `m_iconBuffers`. This keeps the same functionality while removing boilerplate, one heap allocation, and an extra pointer indirection.
</issue_to_address>

### Comment 2
<location> `src/dbus/prelaunchsplashhelper.cpp:19` </location>
<code_context>
+
+Q_LOGGING_CATEGORY(amPrelaunchSplash, "dde.am.prelaunch.splash")
+
+struct PrelaunchSplashHelper::Impl {
+    std::vector<std::unique_ptr<QtWaylandClient::QWaylandShmBuffer>> iconBuffers;
+};
</code_context>

<issue_to_address>
**issue (complexity):** Consider removing the Impl indirection and storing the icon buffers directly as a member to simplify the class’s state management and lifetime handling.

You can simplify the state management by dropping the `Impl` indirection and storing the buffers directly as a member. Since `Impl` only contains `iconBuffers` and there’s no indication of a binary-compatibility requirement here, the extra `std::unique_ptr<Impl>` just adds mental overhead and nullability concerns without a payoff.

### Suggested changes

In the header (`prelaunchsplashhelper.h`), replace the PIMPL:

```cpp
class PrelaunchSplashHelper
    : public QWaylandClientExtensionTemplate<PrelaunchSplashHelper>
{
    Q_OBJECT
public:
    PrelaunchSplashHelper();
    ~PrelaunchSplashHelper() override;

    wl_buffer *buildIconBuffer(const QIcon &icon);
    wl_buffer *createBufferFromPixmap(const QPixmap &pixmap);
    void show(const QString &appId, const QString &iconName);

private:
    struct Impl;
    std::unique_ptr<Impl> m_impl;
};
```

with a direct member:

```cpp
class PrelaunchSplashHelper
    : public QWaylandClientExtensionTemplate<PrelaunchSplashHelper>
{
    Q_OBJECT
public:
    PrelaunchSplashHelper();
    ~PrelaunchSplashHelper() override;

    wl_buffer *buildIconBuffer(const QIcon &icon);
    wl_buffer *createBufferFromPixmap(const QPixmap &pixmap);
    void show(const QString &appId, const QString &iconName);

private:
    std::vector<std::unique_ptr<QtWaylandClient::QWaylandShmBuffer>> m_iconBuffers;
};
```

In the implementation file, delete the `Impl` struct and update usages:

```cpp
// remove this:
// struct PrelaunchSplashHelper::Impl {
//     std::vector<std::unique_ptr<QtWaylandClient::QWaylandShmBuffer>> iconBuffers;
// };

PrelaunchSplashHelper::PrelaunchSplashHelper()
    : QWaylandClientExtensionTemplate<PrelaunchSplashHelper>(1)
{ }

PrelaunchSplashHelper::~PrelaunchSplashHelper() = default;

wl_buffer *PrelaunchSplashHelper::createBufferFromPixmap(const QPixmap &pixmap)
{
    // ... existing code up to wlBuf

    auto *wlBuf = buffer->buffer();
    m_iconBuffers.emplace_back(std::move(buffer));
    return wlBuf;
}

void PrelaunchSplashHelper::show(const QString &appId, const QString &iconName)
{
    if (!isActive()) {
        qCWarning(amPrelaunchSplash, "Skip prelaunch splash (extension inactive): %s", qPrintable(appId));
        return;
    }

    m_iconBuffers.clear();

    // ... rest unchanged
}
```

This keeps all behavior the same while making the object’s lifetime and state management more straightforward (no heap-allocated `Impl`, no extra level of indirection).
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

This PR adds Wayland-based prelaunch splash screen support to the DDE application manager. The implementation introduces a new PrelaunchSplashHelper class that communicates with the compositor via the Wayland protocol to display splash screens when applications are launched. The change requires switching from QCoreApplication to QGuiApplication to enable Wayland and GUI functionality.

Key Changes:

• Added PrelaunchSplashHelper Wayland client extension for requesting splash screens from the compositor
• Integrated splash display trigger into application launch flow (only on Wayland sessions)
• Switched application base class from QCoreApplication to QGuiApplication to support Wayland features

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/dbus/prelaunchsplashhelper.h	New header defining the Wayland client extension class for splash screens
src/dbus/prelaunchsplashhelper.cpp	Implementation of splash helper with icon buffer management and Wayland protocol calls
src/dbus/applicationmanager1service.h	Added splash helper member and accessor method
src/dbus/applicationmanager1service.cpp	Wayland session detection and splash helper initialization logic
src/dbus/applicationservice.cpp	Integration point to trigger splash display during application launch
apps/dde-application-manager/src/main.cpp	Changed from QCoreApplication to QGuiApplication
apps/dde-application-manager/src/CMakeLists.txt	Added Qt6::Gui dependency
src/dbus/CMakeLists.txt	Added Wayland protocol generation and Qt WaylandClient dependencies
CMakeLists.txt	Added Qt6 WaylandClient, Gui components and TreelandProtocols package
debian/control	Added treeland-protocols and qt6-wayland-dev build dependencies
tests/CMakeLists.txt	Updated include paths for generated DBus headers

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/dbus/applicationservice.cpp:342

• Inconsistent null-checking for parent(). The splash helper code checks if parent() is null (lines 325-336), but immediately after, the code uses parent() without null-checking at lines 339, 342, and 367.

Either the null check is unnecessary (if parent is guaranteed to be non-null in production), or the subsequent uses of parent() should also include null checks for consistency and safety. Based on the test setup in tests/ut_applicationmanager.cpp:36, parent() can be null, so the defensive checks should be applied consistently throughout this function.

    // Notify the compositor to show a splash screen if in a Wayland session.
    if (auto *am = parent()) {
        if (auto *helper = am->splashHelper()) {
            const auto iconVar = findEntryValue(DesktopFileEntryKey, "Icon", EntryValueType::IconString);
            const QString iconName = iconVar.isNull() ? QString{} : iconVar.toString();
            qCInfo(amPrelaunchSplash) << "Show prelaunch splash request" << id() << "icon" << iconName;
            helper->show(id(), iconName);
        } else {
            qCInfo(amPrelaunchSplash) << "Skip prelaunch splash (no helper instance)" << id();
        }
    } else {
        qCWarning(amPrelaunchSplash) << "Skip prelaunch splash (no parent ApplicationManager1Service)" << id();
    }

    optionsMap.remove("_hooks");  // this is internal property, user shouldn't pass it to Application Manager
    if (const auto &hooks = parent()->applicationHooks(); !hooks.isEmpty()) {
        optionsMap.insert("_hooks", hooks);
    }
    optionsMap.insert("_builtIn_searchExec", parent()->systemdPathEnv());

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[deepin-bot]

TAG Bot

New tag: 1.2.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #307

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[deepin-ci-robot]

deepin pr auto review

这是一个关于添加 Wayland 预启动启动画面的代码更改。我来分析一下各个方面的改进建议：

1. 代码质量方面：

• 代码结构清晰，新增的 PrelaunchSplashHelper 类职责单一，符合单一职责原则
• 使用了智能指针管理资源，避免内存泄漏
• 日志记录完整，使用了 QLoggingCategory 进行分类日志
• 代码注释规范，使用了 Doxygen 风格的注释

2. 性能方面：

• 使用共享内存缓冲区(wl_buffer)传递图标数据，避免了数据拷贝
• 实现了缓冲区释放机制，及时回收不再使用的资源
• 图标大小选择算法合理，优先选择最接近 128x128 的尺寸

3. 安全性方面：

• 使用 std::nothrow 进行内存分配，避免异常
• 对空指针进行了检查
• 使用 Qt 的类型安全机制，如 qobject_cast

改进建议：

1. 错误处理：

// 在 PrelaunchSplashHelper::show 中添加更详细的错误检查
if (!isActive()) {
    qCWarning(amPrelaunchSplash) << "Prelaunch splash extension is not active";
    return;
}

if (appId.isEmpty()) {
    qCWarning(amPrelaunchSplash) << "Application ID cannot be empty";
    return;
}

2. 资源管理：

// 在 PrelaunchSplashHelper 中添加资源清理
void PrelaunchSplashHelper::cleanup()
{
    // 清理所有未释放的缓冲区
    m_iconBuffers.clear();
}

3. 配置管理：

// 添加配置选项来控制是否启用预启动画面
static const bool PRELAUNCH_SPLASH_ENABLED = []() {
    return QSettings{}.value("Appearance/EnablePrelaunchSplash", true).toBool();
}();

4. 性能优化：

// 添加图标缓存机制
class PrelaunchSplashHelper {
private:
    QCache<QString, QIcon> m_iconCache; // 缓存已加载的图标
};

5. 线程安全：

// 添加互斥锁保护共享资源
class PrelaunchSplashHelper {
private:
    QMutex m_bufferMutex;
    std::vector<std::unique_ptr<QtWaylandClient::QWaylandShmBuffer>> m_iconBuffers;
};

6. 单元测试：

// 添加单元测试
class TestPrelaunchSplashHelper : public QObject {
    Q_OBJECT
private slots:
    void testShow();
    void testBufferManagement();
    void testIconSizeSelection();
};

7. 代码文档：

/**
 * @brief 构造预启动画面助手
 * 
 * 初始化 Wayland 扩展，设置必要的回调函数。
 * 如果 Wayland 显示不可用，对象将保持非活动状态。
 * 
 * @throws std::runtime_error 如果 Wayland 初始化失败
 */
PrelaunchSplashHelper::PrelaunchSplashHelper()

8. 资源限制：

// 添加资源限制检查
static constexpr int MAX_BUFFER_COUNT = 10; // 限制最大缓冲区数量

if (m_iconBuffers.size() >= MAX_BUFFER_COUNT) {
    qCWarning(amPrelaunchSplash) << "Too many pending buffers, skipping new splash";
    return;
}

这些改进建议主要关注：

1. 更健壮的错误处理
2. 更好的资源管理
3. 性能优化
4. 代码可维护性
5. 安全性增强

建议在实现这些改进时，保持代码的简洁性和可读性，避免过度设计。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment