fix: remove virtual device filtering for bluetooth touchpad #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove virtual device detection logic that was preventing bluetooth touchpad natural scrolling settings from being applied. The virtual device check was incorrectly filtering out legitimate bluetooth devices, causing PMS BUG-326583. The changes include: 1. Removed sysfsPath field from mouseInfo and touchpadInfo structs 2. Modified getExtraInfo() to return only devNode and phys 3. Removed isVirtual() methods for both mouse and touchpad 4. Eliminated virtual device filtering in getMouseInfos() and getTPadInfos() Log: Fixed bluetooth touchpad natural scrolling not working issue Influence: 1. Test bluetooth touchpad natural scrolling functionality 2. Verify that all touchpad settings are properly applied 3. Test with various bluetooth touchpad models 4. Ensure no regression in physical device detection 5. Verify that touchpad settings persist after reconnection fix: 移除虚拟设备过滤以修复蓝牙触控板问题 移除了阻止蓝牙触控板自然滚动设置生效的虚拟设备检测逻辑。 虚拟设备检查错误地过滤了合法的蓝牙设备。 变更包括： 1. 从 mouseInfo 和 touchpadInfo 结构中移除 sysfsPath 字段 2. 修改 getExtraInfo() 仅返回 devNode 和 phys 3. 移除鼠标和触控板的 isVirtual() 方法 4. 在 getMouseInfos() 和 getTPadInfos() 中消除虚拟设备过滤 Log: 修复蓝牙触控板自然滚动无效的问题 Influence: 1. 测试蓝牙触控板自然滚动功能 2. 验证所有触控板设置都能正确应用 3. 使用不同型号的蓝牙触控板进行测试 4. 确保物理设备检测没有回归问题 5. 验证触控板设置在重新连接后仍然有效 PMS: BUG-326583
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes legacy sysfsPath support and virtual-device filtering in inputdevice enumeration: the sysfsPath field and related methods are dropped from device info structs, getExtraInfo is simplified to only return devNode and phys, and all isVirtual checks and filters are removed to ensure Bluetooth touchpads are correctly recognized. Class diagram for updated mouseInfo and touchpadInfo structsclassDiagram
class mouseInfo {
*dxinput.Mouse
devNode string
phys string
}
class touchpadInfo {
*dxinput.Touchpad
devNode string
phys string
}
Class diagram for removed isVirtual methodsclassDiagram
class mouseInfo {
~isVirtual() bool // Removed
}
class touchpadInfo {
~isVirtual() bool // Removed
}
Flow diagram for device info filtering logic after PRflowchart TD
A["getMouseInfos()"] --> B["Create mouseInfo from device"]
B --> C["Add to mouse list (no virtual device filtering)"]
A2["getTPadInfos()"] --> B2["Create touchpadInfo from device"]
B2 --> C2["Add to touchpad list (no virtual device filtering)"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Double-check that devices with empty phys values aren’t now merged together incorrectly since sysfsPath filtering was removed.
- Ensure no other code paths or logs still expect the deprecated sysfsPath field or isVirtual methods.
- Consider extracting the shared device-info construction logic in getMouseInfos and getTPadInfos now that the virtual-device checks are gone to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that devices with empty phys values aren’t now merged together incorrectly since sysfsPath filtering was removed.
- Ensure no other code paths or logs still expect the deprecated sysfsPath field or isVirtual methods.
- Consider extracting the shared device-info construction logic in getMouseInfos and getTPadInfos now that the virtual-device checks are gone to reduce duplication.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review我来对这个diff进行审查：
总体来说，这个diff主要简化了代码结构，移除了未使用的功能，但需要注意移除虚拟设备检查可能带来的影响。建议在合并前进行充分测试，确保系统行为符合预期。 |
mhduiy
approved these changes
Nov 6, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove virtual device detection logic that was preventing bluetooth touchpad natural scrolling settings from being applied. The virtual device check was incorrectly filtering out legitimate bluetooth devices, causing PMS BUG-326583.
The changes include:
Log: Fixed bluetooth touchpad natural scrolling not working issue
Influence:
fix: 移除虚拟设备过滤以修复蓝牙触控板问题
移除了阻止蓝牙触控板自然滚动设置生效的虚拟设备检测逻辑。
虚拟设备检查错误地过滤了合法的蓝牙设备。
变更包括：
Log: 修复蓝牙触控板自然滚动无效的问题
Influence:
PMS: BUG-326583
Summary by Sourcery
Remove virtual device filtering to ensure Bluetooth touchpad settings are applied correctly and simplify device info extraction.
Bug Fixes:
Enhancements: