fix: Security options are given default values based on configuration items #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin pr auto review我来对这段代码进行审查，主要从代码逻辑、性能、安全性等方面分析：
改进建议：
// 在 NetManagerThreadPrivate 中缓存转换结果
QString NetManagerThreadPrivate::wpaEapAuthmethod() const
{
static QString cachedMethod = ConfigSetting::instance()->wpaEapAuthmethod().toLower();
return cachedMethod;
}
// 在 NetManager 中添加输入验证
QString NetManager::wpaEapAuthen() const
{
Q_D(const NetManager);
QString auth = d->wpaEapAuthen();
// 添加验证逻辑
if (!isValidAuthMethod(auth)) {
return getDefaultAuthMethod();
}
return auth;
}
function updateIndex() {
try {
var cindex = (root.config802_1x && root.config802_1x.hasOwnProperty("phase2-auth"))
? indexOfValue(root.config802_1x["phase2-auth"])
: indexOfValue(dccData.manager.wpaEapAuthmethod().toLowerCase());
currentIndex = cindex < 0 ? 0 : cindex
} catch (e) {
console.error("Failed to update index:", e);
currentIndex = 0;
}
}这些改进建议可以提升代码的健壮性、性能和可维护性。 |
Reviewer's GuideThis PR introduces two new QML-accessible methods to fetch default WPA-EAP authentication settings from the configuration and updates the UI component to use these dynamic defaults instead of hardcoded values. Sequence diagram for fetching WPA-EAP authentication defaultssequenceDiagram
participant QML_UI
participant NetManager
participant NetManagerPrivate
participant NetManagerThreadPrivate
participant ConfigSetting
QML_UI->>NetManager: wpaEapAuthen()
NetManager->>NetManagerPrivate: wpaEapAuthen()
NetManagerPrivate->>NetManagerThreadPrivate: wpaEapAuthen()
NetManagerThreadPrivate->>ConfigSetting: wpaEapAuthen()
ConfigSetting-->>NetManagerThreadPrivate: default value
NetManagerThreadPrivate-->>NetManagerPrivate: default value
NetManagerPrivate-->>NetManager: default value
NetManager-->>QML_UI: default value
QML_UI->>NetManager: wpaEapAuthmethod()
NetManager->>NetManagerPrivate: wpaEapAuthmethod()
NetManagerPrivate->>NetManagerThreadPrivate: wpaEapAuthmethod()
NetManagerThreadPrivate->>ConfigSetting: wpaEapAuthmethod()
ConfigSetting-->>NetManagerThreadPrivate: default value
NetManagerThreadPrivate-->>NetManagerPrivate: default value
NetManagerPrivate-->>NetManager: default value
NetManager-->>QML_UI: default value
Class diagram for new WPA-EAP authentication methodsclassDiagram
class NetManager {
+QString wpaEapAuthen() const
+QString wpaEapAuthmethod() const
}
class NetManagerPrivate {
+QString wpaEapAuthen() const
+QString wpaEapAuthmethod() const
}
class NetManagerThreadPrivate {
+QString wpaEapAuthen() const
+QString wpaEapAuthmethod() const
}
NetManager --> NetManagerPrivate
NetManagerPrivate --> NetManagerThreadPrivate
NetManagerThreadPrivate --> ConfigSetting
class ConfigSetting {
+QString wpaEapAuthen() const
+QString wpaEapAuthmethod() const
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
mhduiy
approved these changes
Nov 6, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… items Security options are given default values based on configuration items pms: BUG-327883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security options are given default values based on configuration items
pms: BUG-327883
Summary by Sourcery
Provide defaults for enterprise network security options by adding API methods to retrieve configured EAP authentication settings and integrating them into the QML security section.
New Features:
Bug Fixes:
Enhancements: