Skip to content

Conversation

@zsien
Copy link
Contributor

@zsien zsien commented Nov 27, 2024

… not work

判断 sleep-lock 状态

Bug: https://pms.uniontech.com/bug-view-287959.html

@zsien zsien requested a review from a team November 27, 2024 05:43
@ECQZXC
Copy link
Contributor

ECQZXC commented Nov 29, 2024

/approved

fly602
fly602 previously approved these changes Nov 29, 2024
@zsien zsien force-pushed the zs/fix/suspend-lock branch 2 times, most recently from 6860da7 to de70d61 Compare November 29, 2024 05:57
@zsien zsien requested a review from fly602 November 29, 2024 06:03
@zsien zsien force-pushed the zs/fix/suspend-lock branch from de70d61 to 11c0f85 Compare November 29, 2024 06:03
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • LockWorker构造函数中,m_powerGsettings的初始化放在了if语句中,这可能导致m_powerGsettings在某些情况下未被初始化。
  • doPowerAction函数中,m_modelsetIsBlackModesetVisible方法被调用,但没有检查m_model是否为nullptr,可能会导致空指针解引用。
  • doPowerAction函数中的delayTime变量被硬编码为500,建议将其定义为常量或从配置文件中读取。
  • AuthInterface类中新增了m_powerGsettings成员变量,但没有相应的注释说明其用途。

是否建议立即修改:

@zsien zsien merged commit 11a76d7 into linuxdeepin:master Nov 29, 2024
15 of 18 checks passed
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants