sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#2

Summary by Sourcery

Enhancements:

• Add a compilation flag ENABLE_DSS_SNIPE to conditionally control the display of reset password message UI

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request synchronizes source files from the linuxdeepin/dde-session-shell repository. The primary change involves conditionally compiling the reset password message functionality based on the ENABLE_DSS_SNIPE flag.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Conditionally compile reset password message functionality.	Wrapped the showResetPasswordMessage and closeResetPasswordMessage calls within an #ifndef ENABLE_DSS_SNIPE block.	src/session-widgets/auth_password.cpp src/session-widgets/auth_single.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 条件编译的使用：

   • 在auth_password.cpp和auth_single.cpp文件中，使用了#ifndef ENABLE_DSS_SNIPE来控制代码的编译。这种方式可以有效地根据不同的编译选项来启用或禁用某些功能。但是，如果ENABLE_DSS_SNIPE是一个全局宏，建议在项目的编译配置文件中统一管理，而不是在每个源文件中单独处理。

2. 代码重复：

   • auth_password.cpp和auth_single.cpp文件中的updateResetPasswordUI函数有大量的代码重复。建议将重复的代码提取到一个公共函数中，然后在两个文件中调用该函数，以减少代码冗余和维护成本。

3. 缺少注释：

   • 代码中没有添加足够的注释来解释#ifndef ENABLE_DSS_SNIPE宏的作用，以及为什么某些功能在启用ENABLE_DSS_SNIPE时被禁用。添加注释可以帮助其他开发者更好地理解代码的意图和背景。

4. 逻辑判断：

   • 在updateResetPasswordUI函数中，if (m_resetPasswordMessageVisible)和else分支的逻辑是相反的。如果m_resetPasswordMessageVisible为true，则调用showResetPasswordMessage()；如果为false，则调用closeResetPasswordMessage()。这种逻辑判断是合理的，但是建议在代码中添加注释来解释这种逻辑，以便其他开发者更容易理解。

5. 编码风格：

   • 代码中使用了#ifndef ENABLE_DSS_SNIPE来控制代码的编译，这种做法是正确的，但是建议在代码中保持一致的编码风格，例如，如果项目中其他地方使用了类似的条件编译方式，那么应该保持一致。

综上所述，建议对代码进行重构，提取公共函数以减少代码重复，添加必要的注释以提高代码的可读性，并保持一致的编码风格。

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a more descriptive macro name than ENABLE_DSS_SNIPE.
• It looks like the same change is being made in two different files - consider refactoring to share the code.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment